Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add eslint-utils wrappers around deprecated ESLint methods #7914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2023
Merged

chore: add eslint-utils wrappers around deprecated ESLint methods #7914

merged 4 commits into from
Nov 13, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 13, 2023 •
edited
Loading

PR Checklist

Overview

Adds wrapper methods so we can support multiple versions of ESLint, per https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/ -> #7816 -> #7812.

This is a "fix the build ASAP" PR, not a full solution. getAncestors and getScope will need to be updated once / by the time ESLint releases a version that removes their context. methods.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 15b95a9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6552512d5fd50e0008b5f3ad
😎 Deploy Preview https://deploy-preview-7914--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg
Copy link
Member Author

The release flow runs at about 12:00 EST and it's 11:40 EST right now. Cutting it close 😄

@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Nov 13, 2023 •
edited
Loading

I don't know why Node 20 is taking longer on eslint-plugin but the tests all pass locally for me and in the other Node versions. Edit: ah, finished as I was typing. Merging as-is so we have a ✅ main.

FYI @typescript-eslint/triage-team - I'm available to make fast follows if you want to review after the fact.

@JoshuaKGoldberg JoshuaKGoldberg merged commit a54a60b into typescript-eslint:main Nov 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the lint-deprecation-wrappers branch November 13, 2023 16:59
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 14, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Linting broken on main for deprecated ESLint methods
1 participant
@JoshuaKGoldberg