Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(website): use less text for type checked filter #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2023
Merged

chore(website): use less text for type checked filter #7993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/website/src/components/RulesTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export default function RulesTable(): React.JSX.Element {
setMode={(newMode): void =>
changeFilter('typeInformation', newMode)
}
label={`${TYPE_INFORMATION_EMOJI} requires type information`}
label={`${TYPE_INFORMATION_EMOJI} type checked`}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Zamiell, following up on #7666 (comment) 👋

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Cena from #7993 (review) and #7993 (review):

Is the notion of "type checked" mentioned anywhere? To me it could be interpreted as "the rule itself is type checked" and that other rules are like ESLint core rules (just JavaScript running rogue). Me playing devil's advocate though.

Mmmm, I see that the preset is called recommended-type-checked. Maybe that counts as one occasion.

Yeah I think the phrase "type checked" is a good one for us to repeat. It's pretty succinct and I can't think of anything more clear.

/>
<RuleFilterCheckBox
mode={filters.extension}
Expand Down