Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [prefer-readonly] disable checking accessors #8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix(eslint-plugin): [prefer-readonly] disable checking accessors #8300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97f455d
Disable checking accessors for prefer-readonly
Jamesernator Jan 25, 2024
3a393f1
Granular accessor tests
Jamesernator Jan 28, 2024
d2622ac
Update packages/eslint-plugin/src/rules/prefer-readonly.ts
JoshuaKGoldberg Jan 29, 2024
64267cd
fix: formatting and || for isModifierFlagSet suggestion
JoshuaKGoldberg Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/eslint-plugin/src/rules/prefer-readonly.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,10 @@ class ClassScope {
tsutils.isModifierFlagSet(node, ts.ModifierFlags.Private) ||
node.name.kind === ts.SyntaxKind.PrivateIdentifier
) ||
tsutils.isModifierFlagSet(node, ts.ModifierFlags.Readonly) ||
tsutils.isModifierFlagSet(
node,
ts.ModifierFlags.Accessor | ts.ModifierFlags.Readonly,
) ||
ts.isComputedPropertyName(node.name)
) {
return;
Expand Down
20 changes: 20 additions & 0 deletions packages/eslint-plugin/tests/rules/prefer-readonly.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,26 @@ class Foo {
}
}
`,
`
class TestStaticPrivateAccessor {
private static accessor staticAcc = 1;
}
`,
`
class TestStaticPrivateFieldAccessor {
static accessor #staticAcc = 1;
}
`,
`
class TestPrivateAccessor {
private accessor acc = 3;
}
`,
`
class TestPrivateFieldAccessor {
accessor #acc = 3;
}
`,
],
invalid: [
{
Expand Down