Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(eslint-plugin): [no-use-before-define] fix false positive type reference in as, satisfies #8474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 23, 2024
Merged

fix(eslint-plugin): [no-use-before-define] fix false positive type reference in as, satisfies #8474

merged 7 commits into from
Feb 23, 2024

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Feb 14, 2024 •
edited
Loading

PR Checklist

Overview

I think the type reference should not be checked with isInInitializer.

/**
 * Checks whether or not a given reference is inside of the initializers of a given variable.
 *
 * @returns `true` in the following cases:
 * - var a = a
 * - var [a = a] = list
 * - var {a = a} = obj
 * - for (var a in a) {}
 * - for (var a of a) {}
 */
function isInInitializer(

This PR changes isInInitializer to be used only for value references.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 14, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit c389d5e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65d7613ef21854000898d6ca
😎 Deploy Preview https://deploy-preview-8474--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 88 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 14, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c389d5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.89%. Comparing base (f825426) to head (c389d5e).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8474   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files         250      250           
  Lines       12201    12202    +1     
  Branches     3852     3853    +1     
=======================================
+ Hits        10602    10603    +1     
  Misses       1332     1332           
  Partials      267      267
Flag Coverage Δ
unittest 86.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/eslint-plugin/src/rules/no-use-before-define.ts 95.19% <100.00%> (+0.04%) ⬆️

JoshuaKGoldberg
JoshuaKGoldberg requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A nice straightforward logic change that makes sense.

I think just requesting changes on the unit tests to have a bit more testing around both valid & invalid cases. But nothing architectural.

Elmo dancing with a yellow party hat on a blue background

Co-authored-by: @auvred

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Feb 16, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Feb 18, 2024
@yeonjuan
Copy link
Contributor Author

It looks like @typescript-eslint/internal/plugin-test-formatting is failing intermittently in the github action: an error occurred in explicit-function-return-type.test.ts:9, which is unrelated to this PR.

@JoshuaKGoldberg
Copy link
Member

It looks like @typescript-eslint/internal/plugin-test-formatting is failing intermittently in the github action

Yeah, sorry for the noise: #8373

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice! Will defer to @auvred as we were both reviewing. 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 23, 2024
auvred
auvred approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 60c1cd3 into typescript-eslint:main Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@auvred auvred auvred approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
3 participants
@yeonjuan @JoshuaKGoldberg @auvred