Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: fix ast-spec type import snapshot errors #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2024
Merged

chore: fix ast-spec type import snapshot errors #8699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7d93a3
chore: fix ast-spec type import snapshot errors
JoshuaKGoldberg Mar 17, 2024
4dc18dc
Also update babel packages to latest
JoshuaKGoldberg Mar 17, 2024
dc9a14e
chore: rename use-unknown-in-catch-callback-variable.md to .mdx
JoshuaKGoldberg Mar 17, 2024
147b022
Merge branch 'main' into ast-spec-snapshot-fixes
JoshuaKGoldberg Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@
"devDependencies": {
"@actions/core": "^1.10.0",
"@actions/github": "^6.0.0",
"@babel/code-frame": "^7.22.13",
"@babel/core": "^7.23.3",
"@babel/eslint-parser": "^7.23.3",
"@babel/parser": "^7.23.3",
"@babel/types": "^7.23.3",
"@babel/code-frame": "^7.23.5",
"@babel/core": "^7.24.0",
"@babel/eslint-parser": "^7.23.10",
"@babel/parser": "^7.24.0",
"@babel/types": "^7.24.0",
"@eslint/eslintrc": "^2.1.4",
"@eslint/js": "^8.56.0",
"@nx/eslint": "18.0.7",
Expand Down
1 change: 1 addition & 0 deletions ...xtures/type-import-type-with-type-parameters-in-type-reference/snapshots/3-Babel-AST.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 7 additions & 6 deletions ...ype-import-type-with-type-parameters-in-type-reference/snapshots/5-AST-Alignment-AST.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .../ast-spec/src/legacy-fixtures/basics/fixtures/type-import-type/snapshots/3-Babel-AST.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions ...c/src/legacy-fixtures/basics/fixtures/type-import-type/snapshots/5-AST-Alignment-AST.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions ...use-unknown-in-catch-callback-variable.md → ...se-unknown-in-catch-callback-variable.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@
description: 'Enforce typing arguments in `.catch()` callbacks as `unknown`.'
---

import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';

> 🛑 This file is source code, not the primary documentation location! 🛑
>
> See **https://typescript-eslint.io/rules/use-unknown-in-catch-callback-variable** for documentation.

This rule enforces that you always use the `unknown` type for the parameter of a `Promise.prototype.catch()` callback.

<!--tabs-->

### ❌ Incorrect
<Tabs>
<TabItem value="❌ Incorrect">

```ts
Promise.reject(new Error('I will reject!')).catch(err => {
Expand All @@ -26,15 +28,17 @@ Promise.reject(new Error('I will reject!')).catch((err: Error) => {
});
```

### ✅ Correct
</TabItem>
<TabItem value="✅ Correct">

```ts
Promise.reject(new Error('I will reject!')).catch((err: unknown) => {
console.log(err);
});
```

<!--/tabs-->
</TabItem>
</Tabs>

The reason for this rule is to enable programmers to impose constraints on `Promise` error handling analogously to what TypeScript provides for ordinary exception handling.

Expand Down
2 changes: 1 addition & 1 deletion packages/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"typecheck": "tsc -b ./tsconfig.json"
},
"dependencies": {
"@babel/runtime": "^7.22.6",
"@babel/runtime": "^7.24.0",
"@docusaurus/core": "^3.1.1",
"@docusaurus/plugin-client-redirects": "^3.1.1",
"@docusaurus/plugin-pwa": "^3.1.1",
Expand Down
31 changes: 20 additions & 11 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/code-frame@npm:*, @babel/code-frame@npm:^7.0.0, @babel/code-frame@npm:^7.10.4, @babel/code-frame@npm:^7.12.13, @babel/code-frame@npm:^7.16.0, @babel/code-frame@npm:^7.22.13, @babel/code-frame@npm:^7.23.5, @babel/code-frame@npm:^7.8.3":
"@babel/code-frame@npm:*, @babel/code-frame@npm:^7.0.0, @babel/code-frame@npm:^7.10.4, @babel/code-frame@npm:^7.12.13, @babel/code-frame@npm:^7.16.0, @babel/code-frame@npm:^7.23.5, @babel/code-frame@npm:^7.8.3":
version: 7.23.5
resolution: "@babel/code-frame@npm:7.23.5"
dependencies:
Expand All @@ -266,7 +266,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/core@npm:*, @babel/core@npm:^7.11.1, @babel/core@npm:^7.11.6, @babel/core@npm:^7.12.3, @babel/core@npm:^7.19.6, @babel/core@npm:^7.23.2, @babel/core@npm:^7.23.3":
"@babel/core@npm:*, @babel/core@npm:^7.11.1, @babel/core@npm:^7.11.6, @babel/core@npm:^7.12.3, @babel/core@npm:^7.19.6, @babel/core@npm:^7.23.2, @babel/core@npm:^7.23.3, @babel/core@npm:^7.24.0":
version: 7.24.0
resolution: "@babel/core@npm:7.24.0"
dependencies:
Expand All @@ -289,7 +289,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/eslint-parser@npm:*, @babel/eslint-parser@npm:^7.23.3":
"@babel/eslint-parser@npm:*, @babel/eslint-parser@npm:^7.23.10":
version: 7.23.10
resolution: "@babel/eslint-parser@npm:7.23.10"
dependencies:
Expand Down Expand Up @@ -575,7 +575,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/parser@npm:*, @babel/parser@npm:^7.1.0, @babel/parser@npm:^7.14.7, @babel/parser@npm:^7.20.7, @babel/parser@npm:^7.22.7, @babel/parser@npm:^7.23.3, @babel/parser@npm:^7.24.0":
"@babel/parser@npm:*, @babel/parser@npm:^7.1.0, @babel/parser@npm:^7.14.7, @babel/parser@npm:^7.20.7, @babel/parser@npm:^7.22.7, @babel/parser@npm:^7.24.0":
version: 7.24.0
resolution: "@babel/parser@npm:7.24.0"
bin:
Expand Down Expand Up @@ -1717,6 +1717,15 @@ __metadata:
languageName: node
linkType: hard

"@babel/runtime@npm:^7.24.0":
version: 7.24.0
resolution: "@babel/runtime@npm:7.24.0"
dependencies:
regenerator-runtime: ^0.14.0
checksum: 7a6a5d40fbdd68491ec183ba2e631c07415119960083b4fd76564cce3751e9acd2f12ab89575e38496fa389fa06d458732776e69ee1858e366cc3fbdb049f847
languageName: node
linkType: hard

"@babel/template@npm:^7.22.15, @babel/template@npm:^7.24.0, @babel/template@npm:^7.3.3":
version: 7.24.0
resolution: "@babel/template@npm:7.24.0"
Expand Down Expand Up @@ -1746,7 +1755,7 @@ __metadata:
languageName: node
linkType: hard

"@babel/types@npm:^7.0.0, @babel/types@npm:^7.20.0, @babel/types@npm:^7.20.7, @babel/types@npm:^7.22.15, @babel/types@npm:^7.22.19, @babel/types@npm:^7.22.5, @babel/types@npm:^7.23.0, @babel/types@npm:^7.23.3, @babel/types@npm:^7.23.4, @babel/types@npm:^7.23.6, @babel/types@npm:^7.24.0, @babel/types@npm:^7.3.3, @babel/types@npm:^7.4.4, @babel/types@npm:^7.8.3":
"@babel/types@npm:^7.0.0, @babel/types@npm:^7.20.0, @babel/types@npm:^7.20.7, @babel/types@npm:^7.22.15, @babel/types@npm:^7.22.19, @babel/types@npm:^7.22.5, @babel/types@npm:^7.23.0, @babel/types@npm:^7.23.4, @babel/types@npm:^7.23.6, @babel/types@npm:^7.24.0, @babel/types@npm:^7.3.3, @babel/types@npm:^7.4.4, @babel/types@npm:^7.8.3":
version: 7.24.0
resolution: "@babel/types@npm:7.24.0"
dependencies:
Expand Down Expand Up @@ -5715,11 +5724,11 @@ __metadata:
dependencies:
"@actions/core": ^1.10.0
"@actions/github": ^6.0.0
"@babel/code-frame": ^7.22.13
"@babel/core": ^7.23.3
"@babel/eslint-parser": ^7.23.3
"@babel/parser": ^7.23.3
"@babel/types": ^7.23.3
"@babel/code-frame": ^7.23.5
"@babel/core": ^7.24.0
"@babel/eslint-parser": ^7.23.10
"@babel/parser": ^7.24.0
"@babel/types": ^7.24.0
"@eslint/eslintrc": ^2.1.4
"@eslint/js": ^8.56.0
"@nx/eslint": 18.0.7
Expand Down Expand Up @@ -19987,7 +19996,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "website@workspace:packages/website"
dependencies:
"@babel/runtime": ^7.22.6
"@babel/runtime": ^7.24.0
"@docusaurus/core": ^3.1.1
"@docusaurus/module-type-aliases": ^3.1.0
"@docusaurus/plugin-client-redirects": ^3.1.1
Expand Down