test(type-utils): add tests for functions in typeFlagUtils #8956
Conversation
|
Thanks for the PR, @y-hsgw! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| expected: boolean, | ||
| ): void { | ||
| const type = getType(code); | ||
| const result = isTypeFlagSet(type, flagsToCheck); |
There was a problem hiding this comment.
Is the third argument 'isReceiver' in the function 'isTypeFlagSet' necessary?
Considering its usage in the callers of 'isTypeFlagSet', it doesn't seem to be utilized. Hence, I was wondering if it's safe to remove it.
There was a problem hiding this comment.
If it's never used in our code, you can mark it as deprecated and we can remove it later.
There was a problem hiding this comment.
Thanks! Added in 4d6d8ce .
PR Checklist
Overview
add Testcase in typeFlagUtils Functions.