Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test(type-utils): skip mysteriously failing type unit tests #9427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2024
Merged

test(type-utils): skip mysteriously failing type unit tests #9427

merged 5 commits into from
Jun 25, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 25, 2024 •
edited
Loading

PR Checklist

Overview

Comments out the offending tests.

🤷

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 25, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ed00f44
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/667a510d478a64000842c738
😎 Deploy Preview https://deploy-preview-9427--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg
JoshuaKGoldberg commented Jun 25, 2024
View reviewed changes
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 25, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ed00f44. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg changed the title test(type-utils): comment out mysteriously failing type unit tests test(type-utils): skip mysteriously failing type unit tests Jun 25, 2024
kirkwaiblinger
kirkwaiblinger approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ostritch algorithm

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 25, 2024
JoshuaKGoldberg
JoshuaKGoldberg commented Jun 25, 2024
View reviewed changes
Copy link
Member Author

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporter sardonically saying "I hate myself" to an interview microphone, then walking away

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2cdf240 into typescript-eslint:v8 Jun 25, 2024
62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v8-test-failure-fixes branch June 25, 2024 05:38
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jun 25, 2024
Closed
@JoshuaKGoldberg
Copy link
Member Author

Merging now to unblock the v8 branch. Filed #9430 to follow up.

auvred added a commit to auvred/typescript-eslint that referenced this pull request Jun 30, 2024
@auvred
Revert "test(type-utils): skip mysteriously failing type unit tests (t…
5e79c8c 
…ypescript-eslint#9427)"

This reverts commit 2cdf240.
bradzacher pushed a commit that referenced this pull request Jun 30, 2024
@auvred
chore: revert "test(type-utils): skip mysteriously failing type unit …
9eb6cec 
…tests (#9427)" (#9455)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @kirkwaiblinger