Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8 #9559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

feat(eslint-plugin): [no-floating-promises] disable checkThenables by default for v8 #9559

merged 1 commit into from
Jul 14, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

BREAKING CHANGE:
Changes a rule's default option.

PR Checklist

Overview

Changes the option's default from true to false and updates docs + tests.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 13, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d5e4c8c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6692c49b86db700009741c55
😎 Deploy Preview https://deploy-preview-9559--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 13, 2024
Closed
3 tasks
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d5e4c8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 13, 2024 18:18
@codecov Codecov
Copy link

codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (6bd4211) to head (d5e4c8c).

Additional details and impacted files 
@@            Coverage Diff             @@
##               v8    #9559      +/-   ##
==========================================
- Coverage   87.91%   87.90%   -0.02%     
==========================================
  Files         397      397              
  Lines       13558    13558              
  Branches     3939     3939              
==========================================
- Hits        11920    11918       -2     
- Misses       1324     1326       +2     
  Partials      314      314
Flag Coverage Δ
unittest 87.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 98.66% <ø> (-1.34%) ⬇️

kirkwaiblinger
kirkwaiblinger approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 0aa8eac into typescript-eslint:v8 Jul 14, 2024
71 of 84 checks passed
@github-actions github-actions bot mentioned this pull request Jul 14, 2024
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-floating-promises-v8-check-thenables branch January 16, 2025 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bradzacher @kirkwaiblinger