Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(eslint-plugin): disable no-constant-condition in eslint-recommended #9983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(eslint-plugin): disable no-constant-condition in eslint-recommended #9983

wants to merge 1 commit into from

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a disable of no-constant-condition to the eslint-recommended ruleset.

In theory, someone might be on TypeScript <5.6 and the latest version of typescript-eslint. This would reduce their linter surface area. But we already have @typescript-eslint/no-unnecessary-condition.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 35bd4fc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66e43c597c7ef50008a345a7
😎 Deploy Preview https://deploy-preview-9983--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 13, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 35bd4fc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger
Copy link
Member

Wouldn't this be a breaking change?

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft September 16, 2024 13:02
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-no-constant-condition branch October 10, 2024 22:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JoshuaKGoldberg @kirkwaiblinger