Async reference deadlock. #2454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8cc6ad to
a30571f
Compare
…n_memory` to avoid Collection mutex lock.
Unlock Collection mutex before calling `index->run_search` to avoid potential deadlock in case of filter_by Join call being run in parallel with document indexing operation of the referenced collection.
Unlock Collection mutex before calling `prune_doc` to avoid potential deadlock.
Make copies of collection fields before calling `detect_new_fields`.
Add `is_array` property in `reference_info_t`.
a30571f to
785d15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
update_async_references()call intoCollection::batch_index_in_memoryto avoid Collection mutex lock.Collection::search. Unlock before callingindex->run_searchandprune_docmethods.Collection::add_many. Make copies of required collection variables before callingdetect_new_fields.join.cpponcollection.h, callCollectionManagerinstead.PR Checklist