Update ttf-parser, and long tail of RustyBuzz adjacent crates #82
Conversation
|
resvg has a release now |
5fa7e61 to
514b87e
Compare
|
Bumped from the Git based test to the 0.45 tagged release. |
|
There are some CI failures because of clippy and a deprecated upload-artifact action. |
|
Both of those seem to be issues on the |
|
@LaurenzV fixed it on main, so this can be rebased. (Probably clippy should also be pinned to a version like in typst/typst in the future...) |
|
Ugh... Looks like they broke the API of |
|
(I can also take care of the rest if you want, btw, just let me know.) |
...so that RustyBuzz can be updated in Typst without causing duplicates.
|
I will look into it 😅 |
|
Yes pdfium broke their API in a patch level release. Oops. The fix was pretty trivial, so I've addressed that. I don't have time to look at the mass of resvg test failures right now so if you do get to it great. Otherwise I'll take another gander at it tonight. It's probably something trivial like the tooling version being embedded in the output and the expectations being outdated. |
|
Why rollback pdfium? |
I'm confused, isn't that what I wrote before? :p And it also fixes the test failures, apparently something changed in the API which makes it incompatible to the current pdfium version we are linking to. |
|
The tests that are failing don't seem to have anything to do with the change in pdfium versions, and your rollback is not what "fixed" it—or at least at first blush I cannot confirm that it is related. I say fixed in air quotes because for some reason CI is giving you one answer and me a different answer, and my local tests are failing even on main still. Are you sure you can pass: $ cargo test --locked --workspace... on either main or this branch? |
|
Yes, I tried it on main and on this branch and it works now. As soon as I change I presume the reason it fails on main for you is that you have a different build of the C++ pdfium library, which is not compatible with 0.8.20. |
|
Thanks for driving this! |
|
Shall I make a release? |
|
Not urgently necessary from my side, but if you want to sure! |
|
typst/typst#5407 has been open for a while and updating rustybuzz was blocked on this, so if it's a good time for a release from your end I'd do it |
|
Sure then! |
I set out to make sure bumping the RustyBuzz dependency in Typst didn't break anything. It turns out hard to do without ending up with multiple versions of dependencies and conflicting types, but I think I have it all sorted now. This bump will need to be in a release to properly update the lock file, but I already have a working PoC using Git dependencies.
The catch is resvg is going to need a release too. I submitted a PR for that which is already merged, so now it's just a matter of waiting for a release.
When that is released this manifest can get a final tweak before merge to get rid of the Git dependency.