Fix signed integer overflow by casting to uint32_t #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue in arenaAllocator.hpp where left shifting 1 by more than the size of a signed integer caused undefined behavior due to signed integer overflow. The macro MSB_SET has been updated to cast 1 to uint32_t before performing the left shift, ensuring the operation is safe and defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue in arenaAllocator.hpp where left shifting 1 by more than the size of a signed integer caused undefined behavior due to signed integer overflow. The macro MSB_SET has been updated to cast 1 to uint32_t before performing the left shift, ensuring the operation is safe and defined.