Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ua-parser indirectly requires itself #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lexdene opened this issue Nov 29, 2024 · 4 comments · Fixed by #247
Closed

ua-parser indirectly requires itself #246

lexdene opened this issue Nov 29, 2024 · 4 comments · Fixed by #247

Comments

@lexdene
Copy link

lexdene commented Nov 29, 2024

One of the internal systems of the department I'm working in prohibits cyclic dependencies of any kind.
So I cannot install the latest version of ua-parser there.

root@0a4fff0b62e5:~# pip install -q ua-parser pipdeptree
root@0a4fff0b62e5:~# pip freeze
packaging==24.2
pipdeptree==2.24.0
ua-parser==1.0.0
ua-parser-builtins==0.18.0
root@0a4fff0b62e5:~# pipdeptree -p ua-parser
Warning!!! Cyclic dependencies found:
* ua-parser-builtins => ua-parser => ua-parser-builtins
* ua-parser => ua-parser-builtins => ua-parser
------------------------------------------------------------------------
@masklinn
Copy link
Contributor

That's an interesting issue, I'm not too sure how to change it as they do depend on one another.

I guess I could always remove the dependency of ua-parser-builtins on ua-parser and it would just be broken if you install it on its own, something which there is no reason whatsoever to do?

@lexdene
Copy link
Author

lexdene commented Dec 2, 2024

I temporarily fix by installing an old version pip install "ua-parser<1".
So it is not urgent.

masklinn added a commit to masklinn/uap-python that referenced this issue Dec 4, 2024
@masklinn
Remove dependency from ua-parser-builtins
2075310 
It's not super useful, and apparently it causes issues for some tools / workflows (TBF I was surprised pip was fine with it).

Fixes ua-parser#246
@masklinn masklinn mentioned this issue Dec 4, 2024
Merged
masklinn added a commit to masklinn/uap-python that referenced this issue Dec 5, 2024
@masklinn
Remove dependency from ua-parser-builtins
8752879 
It's not super useful, and apparently it causes issues for some tools / workflows (TBF I was surprised pip was fine with it).

Fixes ua-parser#246
masklinn added a commit to masklinn/uap-python that referenced this issue Dec 5, 2024
@masklinn
Remove dependency from ua-parser-builtins
5dfc556 
It's not super useful, and apparently it causes issues for some tools / workflows (TBF I was surprised pip was fine with it).

Fixes ua-parser#246
masklinn added a commit that referenced this issue Dec 5, 2024
@masklinn
Remove dependency from ua-parser-builtins
ca65e02 
It's not super useful, and apparently it causes issues for some tools / workflows (TBF I was surprised pip was fine with it).

Fixes #246
@masklinn
Copy link
Contributor

masklinn commented Dec 5, 2024

I published post releases for all the stables to remove the dependency from the builtins to the main package (I don't think it's possible for prereleases but I assume you don't use that). So there should be no circular dependency anymore.

@lexdene
Copy link
Author

lexdene commented Dec 9, 2024

Now I can install the latest version ua-parser 1.0.0.
Thank you so much ❤️ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency from ua-parser-builtins masklinn/uap-python
2 participants
@masklinn @lexdene