-
Notifications
You must be signed in to change notification settings - Fork 158
Update to latest uap-core #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@mattrobenolt another ping up this release request. 🙏 |
sigh part of the way this project works is it's possible for you to link to whatever files you want as a source of rules. A bump here isn't a requirement. You can set the https://github.com/ua-parser/uap-python/blob/master/ua_parser/user_agent_parser.py#L449-L450 There is a reason why this isn't 100% in sync all the time and I don't bump versions on every single commit upstream. |
Ah, that's super helpful. Would be a good addition to the README to help reduce nagging from folks like me. I'm fine with going that route for now. It does leave the "fix" that I contributed in a halfway complete state but it will get resolved the next time you sync with aup-core. |
The regexes from uap-core have not been updated in this project in over a year. If the authors seriously don't consider updated regexes to be a core mandate of this project then please change the project so that it does not ship with a built-in regex file, but forces the client to provide one, and change the docs to reflect this. I also think the choice of an environment variable is a bit obscure. Providing a setup method on the module would make it more obvious and more flexible to configure. |
So here's the current dilemma updating to latest master ua-parser/uap-core@8783129
So will need to investigate why this test now fails. :( |
I found a relatively painless way to integrate the latest yaml into my build. I just downloaded the rules and committed it in a static directory that gets deployed with my project, and referenced it using a relative path like this before importing
Works well enough. |
Hello, please update to latest (June 2017 or newer). Thanks. |
@mattrobenolt please, what is the status with this? We are currently unable to use uap-python from pip due to old regex definitions... |
The fix is ready to be merged in #59 . |
Fixed by 0.8.0 https://pypi.org/project/ua-parser/0.8.0/ |
@mattrobenolt - unfortunately I missed an issue in
uap-core
that left my fix for Pingdom bot detection incomplete. #53 includes that fix. I'd appreciate another patch release ofuap-python
.Thanks!
The text was updated successfully, but these errors were encountered: