Thanks to visit codestin.com
Credit goes to github.com

Skip to content

uap-core pointing to 10 month old commit #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SrdjanNikitovic opened this issue Jan 21, 2019 · 16 comments
Closed

uap-core pointing to 10 month old commit #68

SrdjanNikitovic opened this issue Jan 21, 2019 · 16 comments

Comments

@SrdjanNikitovic
Copy link

Hello there.

We have a problem that new user agents are not parsed correctly in Python.
After looking investigating the regexes.yaml file, we see that Python library is pointing to a 10 month old commit of uap-core, but the most recent version of uap-core is 10 days old.

Is there a reason why old uap-core is used, or we can use the new one?

@polischouckserg
Copy link

polischouckserg commented Jan 29, 2019

Hi @SrdjanNikitovic, we have forked this repo and updated uap-core here. You can do the same or use our fork.

Related issue #66.

@sjzabel
Copy link

sjzabel commented May 8, 2019

https://github.com/soon/uap-python-next it looks like this project/package may have done the same

@mattrobenolt
Copy link
Member

Good to see that @soon attempted to contribute back the changes needed. I stopped bumping commits from uap-core because tests started to break, and I don't have the bandwidth or capacity to fix them. Bumping versions is trivial and I was doing them regularly until it started to break tests.

@polischouckserg
Copy link

@mattrobenolt there is PR #70 with fixed tests and updated uap-core and it's waiting to be merged.

@Matt343
Copy link

Matt343 commented Aug 13, 2019

Now that the PR has been merged, what do we need to do to get a release created and pushed to pypi?

@admitad-github
Copy link

Only maintainers have rights to create a release and push it to the PyPI.
@mattrobenolt @selwin can you please do this?

@mattrobenolt
Copy link
Member

mattrobenolt commented Aug 17, 2019 via email

@yesthisisjoe
Copy link

Any updates making a new PyPl release? There is a key uap-core fix that my team would be interested in receiving via the update.

@Maggers
Copy link

Maggers commented Sep 11, 2019

Thanks @mattrobenolt - I'm on the Edge engineering team (Chromium based Edge) and we're watching this update closely too as it's impacting users of our Canary, Dev and Beta channels. Would love to see this tagged and uploaded for downstream adoption. Thanks! - Jason

@soon
Copy link

soon commented Sep 12, 2019

Just FYI for everyone waiting for pypi release: I've forked this repo a while ago and deployed to pypi: https://pypi.org/project/ua-parser-next/. It contains the most recent changes from uap-core, passes all tests and allows to pass custom device parses in case if uap-core is not currently supporting them (I needed to parse a new samsung device). The package was renamed to ua_parser_next in order not to conflict with base ua_parser package, all other functions are the same. I'm currently using it in several projects, so if you need the most recent features from uap-core you can try ua-parser-next

@elsigh
Copy link
Contributor

elsigh commented Jan 9, 2020

@soon I would be happy to make you a maintainer/dev on this repo and then you could update from here? I'm a maintainer but don't depend on or use this repo so..

@elsigh
Copy link
Contributor

elsigh commented Jan 9, 2020

Also since I merged #79 I think this particular issue is now moot (but not the overall/future issues)

@elsigh elsigh closed this as completed Jan 9, 2020
@soon
Copy link

soon commented Jan 18, 2020

@elsigh Thank you, will be happy to help

@cyb3a
Copy link

cyb3a commented Feb 4, 2020

@soon sorry to bother you, but do you know when you'll be able to release the new version?
If you don't have the resources in the next couple of weeks, I'd be happy to help out as well.

@soon
Copy link

soon commented Feb 4, 2020

@einhorntee I don't have access to this repo and I'm unable to release it. But I just checked, my fork (https://github.com/soon/uap-python-next) points to the latest commit in master in uap-core. So if switching to fork is an option you can try it

@mattrobenolt
Copy link
Member

I have pushed 0.9.0.

https://pypi.org/project/ua-parser/0.9.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests