-
Notifications
You must be signed in to change notification settings - Fork 158
uap-core pointing to 10 month old commit #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @SrdjanNikitovic, we have forked this repo and updated uap-core here. You can do the same or use our fork. Related issue #66. |
https://github.com/soon/uap-python-next it looks like this project/package may have done the same |
Good to see that @soon attempted to contribute back the changes needed. I stopped bumping commits from uap-core because tests started to break, and I don't have the bandwidth or capacity to fix them. Bumping versions is trivial and I was doing them regularly until it started to break tests. |
@mattrobenolt there is PR #70 with fixed tests and updated uap-core and it's waiting to be merged. |
Now that the PR has been merged, what do we need to do to get a release created and pushed to pypi? |
Only maintainers have rights to create a release and push it to the PyPI. |
Iβll take a look at this today and see whatβs involved at this point. Iβll try to get a release tagged and uploaded today.
β¦ On Aug 16, 2019, at 22:29, Admitad ***@***.***> wrote:
ο»Ώ
Only maintainers have rights to create a release and push it to the PyPI.
@mattrobenolt @selwin can you please do this?
β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Any updates making a new PyPl release? There is a key uap-core fix that my team would be interested in receiving via the update. |
Thanks @mattrobenolt - I'm on the Edge engineering team (Chromium based Edge) and we're watching this update closely too as it's impacting users of our Canary, Dev and Beta channels. Would love to see this tagged and uploaded for downstream adoption. Thanks! - Jason |
Just FYI for everyone waiting for pypi release: I've forked this repo a while ago and deployed to pypi: https://pypi.org/project/ua-parser-next/. It contains the most recent changes from uap-core, passes all tests and allows to pass custom device parses in case if uap-core is not currently supporting them (I needed to parse a new samsung device). The package was renamed to |
@soon I would be happy to make you a maintainer/dev on this repo and then you could update from here? I'm a maintainer but don't depend on or use this repo so.. |
Also since I merged #79 I think this particular issue is now moot (but not the overall/future issues) |
@elsigh Thank you, will be happy to help |
@soon sorry to bother you, but do you know when you'll be able to release the new version? |
@einhorntee I don't have access to this repo and I'm unable to release it. But I just checked, my fork (https://github.com/soon/uap-python-next) points to the latest commit in master in uap-core. So if switching to fork is an option you can try it |
I have pushed 0.9.0. |
Hello there.
We have a problem that new user agents are not parsed correctly in Python.
After looking investigating the regexes.yaml file, we see that Python library is pointing to a 10 month old commit of uap-core, but the most recent version of uap-core is 10 days old.
Is there a reason why old uap-core is used, or we can use the new one?
The text was updated successfully, but these errors were encountered: