Add comment clarifying use of yaml.load, remove requirements file #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d189b5 to
bbc0011
Compare
pyyaml hasn't been a required dependency for a very long time, it's really not clear why ua-parser#70 reintroduced a requirements.txt for it, unless there were points at which `install_requires` was not resolved as a *dependency*, so pyyaml had to be separately installed for `develop` to work? See also: ua-parser#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyyaml hasn't been a required dependency for a very long time, it's
really not clear why #70 reintroduced a requirements.txt for it,
unless there were points at which
install_requireswas not resolvedas a dependency, so pyyaml had to be separately installed for
developto work?See also: #103