Thanks to visit codestin.com
Credit goes to github.com

Skip to content

significantly speed up import time of ua_parser #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions ua_parser/user_agent_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,21 @@
__author__ = "Lindsey Simon <[email protected]>"


if sys.version_info >= (3, 8):
from functools import cached_property
else:
class cached_property:
def __init__(self, func):
self._func = func

def __get__(self, inst, owner):
if inst is None:
return self
else:
ret = inst.__dict__[self._func.__name__] = self._func(inst)
return ret


class UserAgentParser(object):
def __init__(
self, pattern, family_replacement=None, v1_replacement=None, v2_replacement=None
Expand All @@ -37,11 +52,14 @@ def __init__(
v2_replacement: a string to override the matched v2 (optional)
"""
self.pattern = pattern
self.user_agent_re = re.compile(self.pattern)
self.family_replacement = family_replacement
self.v1_replacement = v1_replacement
self.v2_replacement = v2_replacement

@cached_property
def user_agent_re(self):
return re.compile(self.pattern)

def MatchSpans(self, user_agent_string):
match_spans = []
match = self.user_agent_re.search(user_agent_string)
Expand Down Expand Up @@ -100,13 +118,16 @@ def __init__(
os_v4_replacement: a string to override the matched v4 (optional)
"""
self.pattern = pattern
self.user_agent_re = re.compile(self.pattern)
self.os_replacement = os_replacement
self.os_v1_replacement = os_v1_replacement
self.os_v2_replacement = os_v2_replacement
self.os_v3_replacement = os_v3_replacement
self.os_v4_replacement = os_v4_replacement

@cached_property
def user_agent_re(self):
return re.compile(self.pattern)

def MatchSpans(self, user_agent_string):
match_spans = []
match = self.user_agent_re.search(user_agent_string)
Expand Down Expand Up @@ -179,14 +200,18 @@ def __init__(
device_replacement: a string to override the matched device (optional)
"""
self.pattern = pattern
if regex_flag == "i":
self.user_agent_re = re.compile(self.pattern, re.IGNORECASE)
else:
self.user_agent_re = re.compile(self.pattern)
self.regex_flag = regex_flag
self.device_replacement = device_replacement
self.brand_replacement = brand_replacement
self.model_replacement = model_replacement

@cached_property
def user_agent_re(self):
if self.regex_flag == "i":
return re.compile(self.pattern, re.IGNORECASE)
else:
return re.compile(self.pattern)

def MatchSpans(self, user_agent_string):
match_spans = []
match = self.user_agent_re.search(user_agent_string)
Expand Down