Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump version to 0.5.1 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 694 commits into from
Closed

Bump version to 0.5.1 #36

wants to merge 694 commits into from

Conversation

selwin
Copy link
Contributor

@selwin selwin commented Nov 11, 2015

No description provided.

lstrojny and others added 30 commits November 9, 2013 23:07
Modernize PHP port of User Agent Parser
Using regexes.php file instead of regexes.json
This test case shows an IE11 user agent that is identified as
Firefox 12
Sometimes IE11's UserAgent string contains Firefox/12 in it.  The
old pattern order results in this being identified as Firefox/12.

Also, old Firefox versions would include MSIE 6 in it.

In order to correctly identify IE11 and older Firefox, we need to
move the Firefox check after the IE11 check, but before all the
older IE checks.
Conflicts:
	php/src/UAParser/Parser.php
	php/tests/UAParser/Tests/ParserTest.php
[RFC] Splitting PHP parser into multiple single parser classes
Airmail,Outlook,Thunderbird new. Lightning updated
Russell Whitaker and others added 17 commits June 3, 2015 10:47
…ication_device_section

Corrected device_parser section example and family_replacement
Removed js_ua from browser test fixtures & test runner, fixed expectations
This regexp:
   'Android[\- ][\d]+(?:\.[\d]+){1,2}; *[a-z]{0,2}[_\-]?[A-Za-z]{0,2};? Build'

lacks a capturing group (parens) for the device name.  This means that
it needs to specify the device-name specifically in the yaml file,
but it wasn't before.  This fixes that.

Here is a user-agent that triggers the bug:

  Mozilla/5.0 (Linux; Android 5.1.99; Build/MRA23D) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.106 Mobile Safari/537.36
Test Plan:
npm run test
 Fix a bug in one of the Android regexps.
@@ -1,3 +1,4 @@
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has an unresolved merge conflict, which is also reflected on pypi. :(

@mattrobenolt
Copy link
Member

Why does this have 250+ commits? And it causes tests to fail. :( Can this be squashed since it's super hard to figure out what's going on here.

@mattrobenolt
Copy link
Member

This looks like a bad merge imo since these are all commits that have already existed in the repo.

@mattrobenolt
Copy link
Member

Seems the only commit we want is selwin@b6c3dc9 ?

@selwin
Copy link
Contributor Author

selwin commented Nov 11, 2015

Do you mind cherry picking the commit into master?

Sent from my phone

On Nov 12, 2015, at 12:32 AM, Matt Robenolt [email protected] wrote:

Seems the only commit we want is selwin/uap-python@b6c3dc9 ?


Reply to this email directly or view it on GitHub.

@mattrobenolt
Copy link
Member

Yeah, I can do that. I'll create a tag too.

Do you mind giving me permission to pypi so I can upload versions and prevent this from happening again?

@mattrobenolt
Copy link
Member

Pulled in with ef275f5

@selwin
Copy link
Contributor Author

selwin commented Nov 11, 2015

I don't mind, sorry that I've been too busy to properly maintain this. Is there a way to do it on PyPI?

Sent from my phone

On Nov 12, 2015, at 6:52 AM, Matt Robenolt [email protected] wrote:

Yeah, I can do that. I'll create a tag too.

Do you mind giving me permission to pypi so I can upload versions and prevent this from happening again?


Reply to this email directly or view it on GitHub.

@mattrobenolt
Copy link
Member

Oh, no worries at all, this is what open source is about. ❤️

You can go to https://pypi.python.org/pypi?:action=role_form&package_name=ua-parser

Then add me as a Maintainer. My username on pypi is mattrobenolt.

Thanks!

@selwin
Copy link
Contributor Author

selwin commented Nov 11, 2015

Done :)

Win~

On Thu, Nov 12, 2015 at 7:28 AM, Matt Robenolt [email protected]
wrote:

Oh, no worries at all, this is what open source is about. [image: ❤️]

You can go to
https://pypi.python.org/pypi?:action=role_form&package_name=ua-parser

Then add me as a Maintainer. My username on pypi is mattrobenolt.

Thanks!


Reply to this email directly or view it on GitHub
#36 (comment).

@mattrobenolt
Copy link
Member

Awesome, thanks so much. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.