Adding a few words about how to install via pip #37
Conversation
| ### Install via pip | ||
| First, check that you've got the correct dependencies. For example, on Ubuntu: | ||
| ``` | ||
| $ apt-get install libyaml libyaml-dev python-dev |
There was a problem hiding this comment.
These aren't required for pyyaml. They're just optional, so it's not correct to declare these as dependencies.
There was a problem hiding this comment.
Yep, but I can confirm that imports will fail if you install via pip without prior installing these (see #14 (comment))
There was a problem hiding this comment.
This is completely untrue. I just verified with our latest release that it works just fine without libyaml or python-dev.
Can you provide me with some steps to reproduce?
This was with:
- pip 7.1.2
- python 2.7.9
- ua-parser 0.5.1
on Debian Jessie.
There was a problem hiding this comment.
To be clear with what I did, I booted a new Debian docker container and ran:
root@f703d39fc6f7:/# apt-get update && apt-get install -y curl python
root@f703d39fc6f7:/# curl -s https://raw.githubusercontent.com/pypa/pip/master/contrib/get-pip.py | python
root@f703d39fc6f7:/# pip install ua-parserThere was a problem hiding this comment.
And lastly, looking at how we use pyyaml, we don't even attempt to use the c bindings from libyaml anyways.
If we did, we'd have to explicitly do something like, yaml.load(..., Loader=CSafeLoader)
pyyaml doesn't detect the libyaml bindings automatically, unfortunately. :(
|
Thanks @pdelsante, if you update the |
|
Looks good. :) Thanks for the contribution. 🍰 🍨 |
Adding a few words about how to install via pip
I'm adding a few words about how to install the package from pip.
I'm also fixing the imports in the examples; at least when installed from pip,
import user_agent_parserwon't work, you will need something likefrom ua_parser import user_agent_parser.