Fix: restrict concept permissions in role 15 - #153
Merged
pieterlukasse merged 3 commits intoAug 12, 2024
Merged
Conversation
pieterlukasse
force-pushed
the
fix/restric_concept_permissions_in_role_15
branch
from
August 2, 2024 17:55
2da04dc to
fe41f53
Compare
pieterlukasse
marked this pull request as ready for review
August 2, 2024 17:58
pieterlukasse
force-pushed
the
fix/restric_concept_permissions_in_role_15
branch
from
August 2, 2024 18:05
fe41f53 to
cbffd39
Compare
m0nhawk
requested changes
Aug 2, 2024
m0nhawk
approved these changes
Aug 2, 2024
Adding this for completeness...
...linked to specific individual conceptsets
These changes remove the need for having these permissions granted as * permission. Instead, users now get a conceptset specific permission.
pieterlukasse
force-pushed
the
fix/restric_concept_permissions_in_role_15
branch
from
August 12, 2024 15:08
cbffd39 to
5f51983
Compare
pieterlukasse
added a commit
that referenced
this pull request
Apr 10, 2025
* fix: added missing migration line to prev migration script Adding this for completeness... * fix: move too broad conceptset:* permissions to narrow ones ...linked to specific individual conceptsets * fix: added missing readPermissions for conceptsets These changes remove the need for having these permissions granted as * permission. Instead, users now get a conceptset specific permission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1220
Bug Fixes
ConceptSetPermissionSchema.javathat ensures these specific individual permissions are tied to new conceptsets moving forward.Improvements