Feat: add permissions needed for cohort characterization and feature analysis to role 15 - #176
Merged
pieterlukasse merged 2 commits intoMar 14, 2025
Conversation
pieterlukasse
marked this pull request as ready for review
March 7, 2025 18:11
pieterlukasse
marked this pull request as draft
March 7, 2025 18:14
pieterlukasse
force-pushed
the
feat/enable_cohort_characterization_and_fix_permission_issues
branch
3 times, most recently
from
March 11, 2025 19:16
daa0c0a to
76036ea
Compare
This was referenced Mar 11, 2025
pieterlukasse
marked this pull request as ready for review
March 13, 2025 17:40
…d feature analysis to role 15 fix: disable two unecessary global cohort-characterization permissions, incompatible with "teamprojects" ...and improve debug logs fix: add cohort-characterization id to various methods/api calls - This allows for the correct (more strict) permission check to find place based on the user's permissions on the given cohort-characterization - Also expanded the new api patterns into CohortCharacterizationPermissionSchema and removed cohort-characterization permissions that were too broad from role 15 migration script.
pieterlukasse
force-pushed
the
feat/enable_cohort_characterization_and_fix_permission_issues
branch
from
March 13, 2025 17:47
4235a4f to
a68954d
Compare
tianj7
approved these changes
Mar 13, 2025
pieterlukasse
commented
Mar 14, 2025
pieterlukasse
deleted the
feat/enable_cohort_characterization_and_fix_permission_issues
branch
March 14, 2025 20:26
pieterlukasse
added a commit
that referenced
this pull request
Apr 10, 2025
…analysis to role 15 (#176) * feat: add the extra permissions needed for cohort characterization and feature analysis to role 15 fix: disable two unecessary global cohort-characterization permissions, incompatible with "teamprojects" ...and improve debug logs fix: add cohort-characterization id to various methods/api calls - This allows for the correct (more strict) permission check to find place based on the user's permissions on the given cohort-characterization - Also expanded the new api patterns into CohortCharacterizationPermissionSchema and removed cohort-characterization permissions that were too broad from role 15 migration script. * fix: remove wrong/nonsensical(?) role cohort-characterization:design:%s:get
pieterlukasse
added a commit
that referenced
this pull request
Oct 22, 2025
See #176 - parking this part until we are ready to fully implement and test Cohort Characterizations (CC)
pieterlukasse
added a commit
that referenced
this pull request
Oct 22, 2025
See #176 . We will keep this test and code changes for now
pieterlukasse
added a commit
that referenced
this pull request
Oct 24, 2025
See #176 - parking this part until we are ready to fully implement and test Cohort Characterizations (CC)
pieterlukasse
added a commit
that referenced
this pull request
Oct 24, 2025
See #176 . We will keep this test and code changes for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/VADC-1720
https://ctds-planx.atlassian.net/browse/VADC-1602
New Features
Breaking Changes
Bug Fixes
Improvements
Deployment changes
sec_tables in Atlas...so strictly speaking, no real deployment change.