dataquest-dev/dtq-dev sync #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Design fix - added spaces between links * Fix of firstMedataValue null properties
…oad after agreeing (DSpace#874) * Changed logic (condition) of retrieving file download link * Saved the original logic, but changed caching parameter
…ed in the URL, because that query part of the URL was encoded as the filename. (DSpace#873)
* Playright after deploy running here * Using different token * Corrected path in copying json file * Checkout only branch in UI tests not master * Added copilot changes --------- Co-authored-by: Matus Kasak <[email protected]>
* use `$DSPACE_REST_NAMESPACE` for the webapps symlink (cherry picked from commit 9ea936e) * Licenses sync (cherry picked from commit 4ee2f1c) * update header/footer based on latest lindat-common 3.5.0 (cherry picked from commit 7b2f299) * expose both tcp & udp ports of the handle server (cherry picked from commit 46bc936) * Update docker-compose-rest.yml replace ../webapps with /usr/local/tomcat/webapps --------- Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Ondrej Kosarko <[email protected]>
…work properly (DSpace#881) * hotfix - finding index of unchecked box properly to formName arg
* locked searchbar when searchOption is not picked * edited Resource Type search option to not be case-sensitive * edited Resource Type search option to show nothing when there is no match * try to set lowercase constants without toLowerCase method * Added full list of handles for empty Resource Type search option * refactored empty searchQueries handling and added comment for invalid resourcetype search inputs
Co-authored-by: Matus Kasak <[email protected]>
this is the dtq-dev when lindat-2025.06.15781656962 was tagged
…cted (DSpace#897) * Show openaire input field every time the EU type is selected
Co-authored-by: milanmajchrak <[email protected]>
* copied static content that was not already in cs/. Otherwise license page (when without .html) might show an error when UI is in Czech and there's no translation. (cherry picked from commit 9e7eea0) * Update header.component.html I'm expecting the image to take me to lindat.cz. There's no other obvious way to navigate out of the repository * This is the change from ufal/clarin-dspace@5fc2414 but applied on v7 * Adding a note about the proprietor change --------- Co-authored-by: Ondrej Kosarko <[email protected]> Co-authored-by: Michal Kren <[email protected]>
* show msg about no files when item has no files, show no spinenr * check if files are array * check files size * fix error * optimize template with hasNoFiles flag * used behaviourSubject for hasNoFiles / aynchronous
* Created trigger for running UI tests for each customer daily * Corrected spaces * Changed name of the tests --------- Co-authored-by: Matus Kasak <[email protected]>
* Added loading spinner icon after 'I agree' button is clicked * Removed type annotation and rephrased comment * Changes isLoading to async object * Edited loading spinner visibility method - consistency fix
* The user always see it's submissions page --------- Co-authored-by: Paurikova2 <[email protected]>
Co-authored-by: Matus Kasak <[email protected]>
contains lindat-2025.07.16198085191
There was a problem hiding this comment.
Pull Request Overview
Syncs and adds static license agreement HTML pages for Universal Dependencies versions 2.6, 2.7, 2.15, and 2.16.
- Adds complete license agreement files for v2.6, v2.7, v2.15, v2.16 including treebank tables and license references.
- Ensures the additional software tools license version is updated per release.
- Provides full tables of languages, treebanks, and their associated licenses for each version.
Reviewed Changes
Copilot reviewed 77 out of 91 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/static-files/cs/license-ud-2.7.html | New license page for UD v2.7 with treebank license table. |
| src/static-files/cs/license-ud-2.6.html | New license page for UD v2.6 with treebank license table. |
| src/static-files/cs/license-ud-2.15.html | New license page for UD v2.15 with updated GPL and CDLA licenses. |
| src/static-files/cs/license-ud-2.16.html | New license page for UD v2.16 with updated tool license to GPL 3. |
Comments suppressed due to low confidence (3)
src/static-files/cs/license-ud-2.7.html:1
- [nitpick] The id 'faq-like' is very generic and reused in multiple versioned pages. Consider making it version-specific (e.g., 'faq-like-2-7') to avoid confusion.
<div id="faq-like">
src/static-files/cs/license-ud-2.7.html:2
- [nitpick] The id 'ufal-point-faq' is reused across versions. To improve specificity for styling or linking, consider appending the version number (e.g., 'ufal-point-faq-2-7').
<h2 id="ufal-point-faq">Universal Dependencies v2.7 License Agreement</h2>
src/static-files/cs/license-ud-2.7.html:19
- The paragraph uses 'GNU GPL Version 2' while the licenses table lists 'GNU GPL 2.0'. Align the naming to one form for consistency and clarity.
under GNU GPL Version 2.</p>
| @@ -0,0 +1,706 @@ | |||
| <div id="faq-like"> | |||
There was a problem hiding this comment.
[nitpick] These static HTML files share almost identical structure and tables. Consider generating them from a single template or data source to reduce duplication and simplify updates for future versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncing dtq-dev ~lindat-2025.07.16198085191:
UFAL/Added same spacing styles via bootstrap as in login page (dataquest-dev#862)
UFAL/Fixed editing of extended license labels
UFAL/License agreement page component errors (dataquest-dev#867)
UFAL/Ask Only Once license not downloading bitstream without page reload after agreeing (dataquest-dev#874)
UFAL/License Administration Labels & Required Info checkboxes should work properly (dataquest-dev#881)
UFAL/Searching problems in Manage Handles table (dataquest-dev#882)
UFAL/License agreement loading spinner after submitting (dataquest-dev#892)
UI tests for each customer (dataquest-dev#865)
Updating UI tests after import (dataquest-dev#887)
Trigger automated ui tests (dataquest-dev#905)
Changed runner in playwright tests (dataquest-dev#914)
UFAL/Publisher search redirect not work dataquest-dev#880 (dataquest-dev#904)
Ufal/commits from ok lindat (dataquest-dev#903)
UFAL/show-no-spinner-when-item-has-no-files (dataquest-dev#902)
The filename wasn't properly encoded when it has ?sequence...&isAllowed in the URL, because that query part of the URL was encoded as the filename. (dataquest-dev#873)
UFAL/Show openaire input field every time the EU funding type is selected (dataquest-dev#897)
UFAL/User cannot see his submission (dataquest-dev#910)
Merge commit 'c15d94c1c' into HEAD
Merge remote-tracking branch 'dataquest-dev/dtq-dev' into HEAD
Ufal dtq sync062025 (dataquest-dev#877)