Merged
Conversation
uloco
requested changes
Dec 18, 2022
Owner
uloco
left a comment
There was a problem hiding this comment.
Thank you so much for this PR :)
I have some minor nitpicks, that would improve things in my opinion:
- You could use t.type als a fg for all target highlights, so it's better visible
- I think the alternate buffer is too visible, how about we keep the text as BufferInactive but just highlight the BufferAlternateSign with t.constant?
- To make this also work with transparent mode, we should add the bgs to the init.lua transparent section.
BufferInactive { theme.BufferInactive, bg = "NONE" },
BufferVisible { BufferCurrent }
lua/lush_theme/bluloco.lua
Outdated
| BufferVisibleERROR { BufferInactiveERROR }, | ||
| BufferVisibleHINT { BufferInactiveHINT }, | ||
|
|
||
| BufferAlternate { BufferInactive, fg = t.tag }, |
Owner
There was a problem hiding this comment.
I think this is just too much for a alternate buffer, probalby the sign only would be better, see below
Suggested change
| BufferAlternate { BufferInactive, fg = t.tag }, | |
| BufferAlternate { BufferInactive }, |
lua/lush_theme/bluloco.lua
Outdated
| BufferAlternateIndex { BufferAlternate }, | ||
| BufferAlternateIcon { BufferAlternateIndex }, | ||
| BufferAlternateMod { BufferInactiveMod }, | ||
| BufferAlternateSign { BufferInactiveSign }, |
Owner
There was a problem hiding this comment.
blue would be just too close to the actual current one. how about purple for alternate sign?
Suggested change
| BufferAlternateSign { BufferInactiveSign }, | |
| BufferAlternateSign { BufferInactiveSign, fg = t.constant }, |
Contributor
Author
There was a problem hiding this comment.
ok, here's how that looks now;
…fy tabpage groups; set BufferCurrent to use Normal for transparency
uloco
approved these changes
Dec 22, 2022
Owner
uloco
left a comment
There was a problem hiding this comment.
Love it, thank you so much again :)
paponahmedsharad
pushed a commit
to paponahmedsharad/bluloco.nvim
that referenced
this pull request
Jan 27, 2023
Add Barbar support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample barbar bufferline;
samples via
Lushifycall;