Merged
Conversation
Owner
|
I was just going about fixing this. Thank you :) Do you think we should switch fg and bg? So it is easier to read? |
Owner
|
I think the behavior changed a little as well with the LeapMatch and LeapLabel highlight groups. When I compare with the defaults... How about something like this, so it is easier to read and differentiate? LeapMatch { fg = t.keyword, gui = "underline", sp = t.keyword },
LeapLabel { bg = t.keyword, fg = t.bg },
LeapBackdrop { fg = t.shade40 }, |
Owner
|
I am not using leap myself actively so please help me make it sensible. |
7470fd9 to
ea93218
Compare
Author
|
With background looks nice too. I added the changes to the PR. |
ea93218 to
0ea3bdd
Compare
uloco
approved these changes
Jul 9, 2024
Owner
uloco
left a comment
There was a problem hiding this comment.
Thank you for finding and fixing this. Have a good one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issue #79 (comment)