NOISSUE - Guard chat against weak retrieval context#254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix because it prevents chat responses from being generated from empty or weak retrieval context.
What does this do?
This PR improves grounded chat behavior when retrieval returns no useful context.
Previously, if retrieval returned no chunks or returned unrelated chunks, the chat service could still call the LLM. That allowed the model to produce weak or misleading
answers from irrelevant records.
With this change:
Which issue(s) does this PR fix/relate to?
N/A
Have you included tests for your changes?
Yes, I have included tests for this change.
The tests cover:
Verified with:
go test ./internal/embedder/servicego test ./internal/embedder/...Did you document any new/modified features?
No, this is an internal chat retrieval behavior fix and does not add a new user-facing feature.
Notes
Manually verified that unrelated questions now return a no-relevant-information response, while relevant queries such as record/person name lookups only pass matching
chunks to the model.