Add ATOM integration#256
Merged
Merged
Conversation
Signed-off-by: Arvindh <[email protected]>
# Conflicts: # docker/.env # docker/cube-compose.yaml # docker/traefik/dynamic.toml # ui/src/context/AuthContext.tsx # ui/src/layouts/AppLayout.tsx # ui/src/lib/auth/magistrala-service.http.test.ts # ui/src/lib/auth/magistrala-service.ts # ui/src/lib/embedder/service.ts # ui/src/lib/platform/service.ts # ui/src/pages/AuthPage.tsx # ui/src/pages/ChatPage.tsx # ui/src/pages/ConfigPage.tsx # ui/src/pages/InvitationsPage.tsx # ui/src/pages/MembersPage.tsx # ui/src/pages/WorkspacesPage.tsx # ui/vite.config.ts
- Polyfill localStorage/sessionStorage in test setup; jsdom under vitest does not expose the Web Storage API, breaking atom-auth-service tests. - Ignore underscore-prefixed unused args in eslint no-unused-vars rule. - Mark intentional setState-in-effect resets with disable comments. Co-Authored-By: Claude Opus 4.8 <[email protected]>
- err113: replace dynamic errors with wrapped static sentinels in agent, atomcerts, and internal/atom. - contextcheck: derive proxy shutdown context via context.WithoutCancel. - noctx: use db.PingContext in proxy postgres setup. - staticcheck SA1019: replace deprecated trace.NewNoopTracerProvider with trace/noop.NewTracerProvider. - errchkjson: marshal before writing JSON responses. - goconst/unparam/exitAfterDefer/nestif/lll/revive: assorted cleanups, extract setupCertProvider helper in cmd/agent. - golangci config: disable noisy gocritic hugeParam; exclude tagliatelle for ATOM API structs whose JSON tags mirror the camelCase wire contract.
- exitAfterDefer: refactor cmd/proxy main into a run() error helper so os.Exit/log.Fatal never skip deferred cleanup. - maintidx: exclude test files; table-driven tests are inherently large. - exclude ui/node_modules vendored Go from linting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified features?
Notes