Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added custom RichTextRegexValidator to validate markup instead of JSON #19045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v13/dev
Choose a base branch
from

Conversation

tomvanenckevort
Copy link
Contributor

@tomvanenckevort tomvanenckevort commented Apr 15, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #19044

Description

I've taken inspiration from a previous change where a custom required validator was added for RTE fields: #16962

In the same style I added RichTextRegexValidator which inherits the default RegexValidator and ensures that it gets the RTE's Markup value before passing it to the base ValidateFormat method.

In the RichTextPropertyEditor class I have overridden the default FormatValidator with the new custom one.

To test this, please follow the same reproduction steps as mentioned in the issue and confirm that the node containing the RTE with a custom regular expression now can be saved & published successfully.

image


This item has been added to our backlog AB#52413

Copy link

github-actions bot commented Apr 15, 2025

Hi there @tomvanenckevort, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @tomvanenckevort, thanks a lot for your PR to fix #19044 - someone on the core collaborators team will review this soon 😄

@nielslyngsoe nielslyngsoe added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Apr 30, 2025
@Migaroez
Copy link
Contributor

Migaroez commented May 5, 2025

Hey @georgebid and @tomvanenckevort I will be having a look at this one.

@iOvergaard iOvergaard changed the base branch from v13/contrib to main May 5, 2025 12:30
@Migaroez Migaroez changed the base branch from main to v13/dev May 5, 2025 15:33
@Migaroez
Copy link
Contributor

Migaroez commented May 5, 2025

Hey @tomvanenckevort I pushed some changes to make it non breaking. Could you test again on your end? For me it looked as the issue was still solved. Thank you for doing the hard work for me 🤗

@tomvanenckevort
Copy link
Contributor Author

@Migaroez Yes, that all works and looks good to me.
I hadn't taken into account that one of those changes was a breaking one, so thanks for sorting that out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants