-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Added custom RichTextRegexValidator to validate markup instead of JSON #19045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v13/dev
Are you sure you want to change the base?
Added custom RichTextRegexValidator to validate markup instead of JSON #19045
Conversation
Hi there @tomvanenckevort, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @tomvanenckevort, thanks a lot for your PR to fix #19044 - someone on the core collaborators team will review this soon 😄 |
Hey @georgebid and @tomvanenckevort I will be having a look at this one. |
Hey @tomvanenckevort I pushed some changes to make it non breaking. Could you test again on your end? For me it looked as the issue was still solved. Thank you for doing the hard work for me 🤗 |
@Migaroez Yes, that all works and looks good to me. |
Prerequisites
If there's an existing issue for this PR then this fixes #19044
Description
I've taken inspiration from a previous change where a custom required validator was added for RTE fields: #16962
In the same style I added
RichTextRegexValidator
which inherits the defaultRegexValidator
and ensures that it gets the RTE's Markup value before passing it to the baseValidateFormat
method.In the
RichTextPropertyEditor
class I have overridden the defaultFormatValidator
with the new custom one.To test this, please follow the same reproduction steps as mentioned in the issue and confirm that the node containing the RTE with a custom regular expression now can be saved & published successfully.
This item has been added to our backlog AB#52413