add auto scroll in dropdown user group filter #19084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nielslyngsoe
reviewed
May 5, 2025
| @@ -242,6 +242,8 @@ export class UmbUserCollectionHeaderElement extends UmbLitElement { | |||
| gap: var(--uui-size-space-3); | |||
| flex-direction: column; | |||
| padding: var(--uui-size-space-3); | |||
| overflow-y: auto; | |||
| max-height: 500px; | |||
There was a problem hiding this comment.
Hi @NguyenThuyLan
Great to add a scrollbar, but assuming a specific height is not so great. — If a user has a really large screen it would be annoying to only get 500px of this dropdown. In otherwords if the user are viewing this in a very tall window it might be too big.
So I would recommend investigating if we can solve this in another way, where we do not assume the available screen estate?
Not that I know what options are available in CSS in this specific case, but if there is a way to limit the dropdown height to the available space, then that would be ideal, so please investigate if there is any opportunities to avoid fixed sizes.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description
This PR fixes for #19073