Feature: ability to drag across tabs #19183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements native drag and drop support for sorting groups and properties across tabs. Key changes include refactoring the sorter controller to handle external drag events, adding new external drop, remove, and insert callback methods in content type editors, and updating container management to support the new behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts | Updated core sorter logic to support native drag n' drop and external move requests |
| src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor.element.ts | Added dragover handler to update browser history during tab drag events |
| src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor-tab.element.ts | Introduced new external drop and remove/insert callbacks for tab editor interactions |
| src/Umbraco.Web.UI.Client/src/packages/content/content-type/workspace/views/design/content-type-design-editor-properties.element.ts | Added external drag-drop callbacks for property editor elements |
| src/Umbraco.Web.UI.Client/src/packages/content/content-type/structure/content-type-structure-manager.class.ts | Refactored container insertion and removal functionality to align with drag n' drop changes |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts:1326
- [nitpick] The renaming from notifyRequestDrop to notifyRequestMove may be confusing. Clarify the callback naming and update the documentation to ensure it distinguishes between external drop and move requests.
if (this.notifyRequestMove({ item: item }) === true) {
src/Umbraco.Web.UI.Client/src/packages/core/sorter/sorter.controller.ts
Outdated
Show resolved
Hide resolved
…nto v16/feature/ability-to-drag-across-tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Sorter to support Native Drag n' Drop. Though only from and to the same data-set as the receiver has to be able to remove from the sender.
This enable us to Sort Groups and Properties across Tabs.