Saveable workspace interface + token #19220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a saveable workspace interface and token to enable a saving action without closing the modal, which is particularly useful for document workspaces when validation errors are present. Key changes include replacing submit actions with save actions, introducing a new context token and interface for saveable workspaces, and updating the content detail workspace to support saving without automatically closing the modal.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/packages/documents/workspace/document-workspace.context.ts | Replaces public requestSubmit() with a protected _handleSave() method that calls the parent save handler. |
| src/packages/documents/workspace/document-workspace.context-token.ts | Updates the context token type from UmbSubmittableWorkspaceContext to UmbWorkspaceContext. |
| src/packages/documents/workspace/actions/save.action.ts | Changes the workspace action from submit to save by switching base classes and argument types. |
| src/packages/core/workspace/submittable/submittable-workspace-context-base.ts | Adds a _validateAndLog() method to wrap validation with logging and rejection. |
| src/packages/core/workspace/contexts/tokens/saveable-workspace.context-token.ts & .../saveable-workspace.context.interface.ts | Introduces a saveable workspace context token and interface. |
| src/packages/core/workspace/components/workspace-action/common/save/* | Implements a new save action with context retrieval and execution logic that calls requestSave(). |
| src/packages/content/content/workspace/content-detail-workspace-base.ts | Updates the content detail workspace context to implement UmbSaveableWorkspaceContext and distinguishes between saving and submitting, affecting modal closing behavior. |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/content/content/workspace/content-detail-workspace-base.ts:788
- Review the contrasting behavior between requestSave (which does not close the modal) and _handleSubmit (which unconditionally calls _closeModal). Confirm that this difference is intentional for UX consistency across different workspace types.
public requestSave() {
...braco.Web.UI.Client/src/packages/documents/documents/workspace/document-workspace.context.ts
Show resolved
Hide resolved
....Web.UI.Client/src/packages/core/workspace/submittable/submittable-workspace-context-base.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a Saveable Workspace Interface and Token to enable just saving without submitting. Because Submit closes the modal, and we do not want to close the modal in Document Workspaces, cause the save method in those are not the primary action and neither is validation preventing the save to be successful, meaning when errors are present we previously just closed the modal. This changes that.
Please test Block Workspaces and others.