implement label for entity actions bundle #19242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements labels for various entity action bundles to eliminate console warnings and improve label consistency. Key changes include adding a "name" property to the value object in multiple collection view components, updating the label rendering to use localized terms, and modifying dropdown and entity action components to support the new label structure.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/packages/user/.../user-table-collection-view.element.ts | Added "name: user.name" to the payload. |
| src/packages/user-group/.../user-group-table-collection-view.element.ts | Added "name: userGroup.name" to the payload. |
| src/packages/members/.../member-table-collection-view.element.ts | Added "name: member.name" to the payload. |
| src/packages/members/.../member-group-table-collection-view.element.ts | Added "name: memberGroup.name" to the payload. |
| src/packages/media/.../media-table-collection-view.element.ts | Added "name: item.name" to the payload. |
| src/packages/media-types/.../media-type-tree-item-table-collection-view.element.ts | Added "name: item.name" to the payload. |
| src/packages/language/.../language-table-collection-view.element.ts | Added "name: language.name" to the payload. |
| src/packages/extension-insights/.../extension-table-collection-view.element.ts | Added "name: extension.name" to the payload. |
| src/packages/documents/.../document-entity-actions-table-column-view.element.ts | Left a TODO comment regarding missing name handling. |
| src/packages/documents/.../document-type-tree-item-table-collection-view.element.ts | Added "name: item.name" to the payload. |
| src/packages/data-type/.../data-type-tree-item-table-collection-view.element.ts | Added "name: item.name" to the payload. |
| src/packages/core/tree/.../tree-item-element-base.ts | Replaced inline label extraction with a localized _label property. |
| src/packages/core/menu/section-sidebar-menu-with-entity-actions.element.ts | Updated label to a localized term using manifest meta label. |
| src/packages/core/menu/components/menu-item-layout.element.ts | Updated label to a localized term using the current label property. |
| src/packages/core/entity-action/global-components/entity-actions-table-column-view.element.ts | Extended the union type and updated label rendering but used a type cast for name. |
| src/packages/core/components/entity-actions-bundle/entity-actions-bundle.element.ts | Added label to the dropdown and action list elements. |
| src/packages/core/components/dropdown/dropdown.element.ts | Modified label property to be optional and provided a fallback value. |
| src/packages/clipboard/clipboard-entry/picker/clipboard-entry-picker.element.ts | Updated label to be rendered as a localized term. |
| src/assets/lang/en.ts & da-dk.ts | Added localized functions for "viewActionsFor". |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/src/packages/core/entity-action/global-components/entity-actions-table-column-view.element.ts:17
- Instead of using a type cast with 'as any', consider refining the type definition for 'value' (e.g. using UmbNamedEntityModel) and implementing a proper type guard to access the name property.
label=${this.localize.term('actions_viewActionsFor', [(this.value as any).name])}>
...s/collection/views/table/column-layouts/document-entity-actions-table-column-view.element.ts
Show resolved
Hide resolved
madsrasmussen
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement labels to avoid seeing the console warnings and fixing so we get some more labels