Chore: Relocates "media-type-root" to under "workspace" #19245
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the folder structure by relocating the “media-type” and “media-type-root” packages under the “workspace” folder, aligning them with the “document-types” structure.
- Updates relative import paths in multiple files to reflect the new locations.
- Refactors manifests and index/constant exports for consistency.
- Removes an obsolete workspace manifest entry in the tree manifests.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| media-type-workspace-view-structure.element.ts | Adjusted import path for the input element component to the new structure. |
| media-type-workspace.context.ts | Updated relative import paths for entity, types, and constants. |
| media-type/manifests.ts | Added manifests reflecting the new workspace configuration. |
| media-type/index.ts | Updated exports to route through the new media-type module. |
| media-type/constants.ts | Created new constant exports for the workspace alias and context. |
| media-type-root/manifests.ts | Adjusted import path for the entity to match the new folder location. |
| manifests.ts (workspace) | Consolidated manifests by merging media-type and media-type-root arrays. |
| index.ts (workspace) | Updated export to reference the new media-type index file. |
| constants.ts (workspace) | Re-exported constants from both media-type and media-type-root modules. |
| tree-item-children/manifests.ts | Corrected import path for the media-type-root workspace alias. |
| tree/manifests.ts | Removed an obsolete workspace manifest for media-type-root. |
| constants.ts (media-types) | Removed re-export of media-type-root constants to reflect the new location. |
Comments suppressed due to low confidence (2)
src/Umbraco.Web.UI.Client/src/packages/media/media-types/workspace/media-type/views/structure/media-type-workspace-view-structure.element.ts:2
- Verify that the updated relative import path reflects the new file structure consistently.
import type { UmbInputMediaTypeElement } from '../../../../components/input-media-type/input-media-type.element.js';
src/Umbraco.Web.UI.Client/src/packages/media/media-types/tree/tree-item-children/manifests.ts:6
- Confirm that the revised import path for UMB_MEDIA_TYPE_ROOT_WORKSPACE_ALIAS aligns with the new location of media-type-root.
import { UMB_MEDIA_TYPE_ROOT_WORKSPACE_ALIAS } from '../../workspace/media-type-root/constants.js';
|
Hi @leekelleher I personally think we should move in the opposite direction. Instead of relocating This change would also allow us to split the path.ts, entity.ts, entity actions, and so on into their respective areas. I believe this separation will provide a clearer distinction between the files 🙂 |
Okay, that's good with me. I'd assumed that "document-types" was the structure to follow (for content type workspaces). I'm happy to re-organise it. 👍 |
Description
Aligns the folder structure of the "media-types" sub-package with "document-types", by relocating the "media-type" and "media-type-root" to under the "workspace" folder.
No functional changes. Exports should remain intact.