Fix #19221 #19254
Merged
Fix #19221 #19254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a UI layering issue as documented in issue #19221 by adjusting CSS z-index values and ensuring consistent attribute usage for extension components.
- Adds the 'part' attribute to extension components in block entry elements
- Introduces a shared style block for extension component parts to manage z-index
- Updates the custom view component’s z-index to correctly layer the UI
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/block/block-rte/components/block-rte-entry/block-rte-entry.element.ts | Adds setting of the 'part' attribute and inserts a style block for proper stacking |
| src/Umbraco.Web.UI.Client/src/packages/block/block-list/components/block-list-entry/block-list-entry.element.ts | Adds setting of the 'part' attribute and inserts a style block for proper stacking |
| src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-entry/block-grid-entry.element.ts | Adds setting of the 'part' attribute and inserts a style block for proper stacking |
| src/Umbraco.Web.UI.Client/examples/block-custom-view/block-custom-view.ts | Adjusts custom view CSS and updates z-index values to fix UI overlap issues |
Comments suppressed due to low confidence (1)
src/Umbraco.Web.UI.Client/examples/block-custom-view/block-custom-view.ts:34
- [nitpick] Verify that the new high z-index value is intentional and consistently fits within the overall stacking context to avoid potential overlap issues with other UI elements.
z-index: 10000;
...UI.Client/src/packages/block/block-rte/components/block-rte-entry/block-rte-entry.element.ts
Show resolved
Hide resolved
...Client/src/packages/block/block-list/components/block-list-entry/block-list-entry.element.ts
Show resolved
Hide resolved
...Client/src/packages/block/block-grid/components/block-grid-entry/block-grid-entry.element.ts
Show resolved
Hide resolved
madsrasmussen
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19221
This screenshot is from the Custom View Example which has elements with z-index 1000, before this fix that was ruining the UI, now it stays behind.