Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ronaldbarendse
Copy link
Contributor

πŸ“‹ Description

Product license keys on v14 and up have moved from Umbraco:Licenses: to Umbraco:Licenses:Products: to allow adding other configuration settings below the same section (on v13, Umbraco:LicensesOptions: was used for this).

Because the license configuration is the same for all products, should we also consolidate this into a generic page within the DXP site? The existing product-specific pages can still have the example configuration with the correct product ID, but all other options can then be moved into a single (major version specific?) page.

βœ… Contributor Checklist

I've followed the Umbraco Documentation Style Guide and can confirm that:

  • Code blocks are correctly formatted.
  • Sentences are short and clear (preferably under 25 words).
  • Passive voice and first-person language (β€œwe”, β€œI”) are avoided.
  • Relevant pages are linked.
  • All links work and point to the correct resources.
  • Screenshots or diagrams are included if useful.
  • Any code examples or instructions have been tested.
  • Typos, broken links, and broken images are fixed.

πŸ“š Helpful Resources

Copy link

The Link Checker found broken links in your PR.
Please review the following list:

Broken links found in: 16/umbraco-deploy/installation/the-licensing-model.md

βš“ Anchor not found β†’ 16/umbraco-deploy/installation/images/licenses-screen.png | Cannot find file

Broken links found in: 16/umbraco-ui-builder/getting-started/licensing-model.md

βš“ Anchor not found β†’ 16/umbraco-ui-builder/getting-started/licensing-model.md#add-additional-domains | Cannot find fragmentFull Github Actions output

@eshanrnh
Copy link
Contributor

Thanks for the PR, @ronaldbarendse πŸ™Œ Since the license key configuration applies from v14 and up, shouldn't we also update the v15 articles/docs to keep them consistent?

Regarding consolidating the information into a generic page within the DXP docs, it definitely makes a lot of sense. That way, we only maintain the details in one place. At the same time, the product-specific pages can keep a minimal example with the correct product ID and a link back to the generic page for the full options and explanation.

Let me know if there is anything I can do to help πŸ’ͺ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants