fix(utoopack): filter packageImports for legacy antd#13338
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Size Change: +130 B (0%) Total Size: 10.1 MB 📦 View Changed
ℹ️ View Unchanged
|
b4ea54c to
60dff0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
antd.importsignal for legacy antd import-style handlingantdfrom user-providedutoopack.optimization.packageImportswhen antd is also handled by modularized importsantdpackageImports untouched when the antd import pipeline is disabledThis avoids combining
packageImports: ['antd']with the antd v4babel-plugin-import/modularizeImportsstyle pipeline, which can drop antd v4 style side-effect chunks under utoopack.Note: @utoo/pack also has an internal default packageImports list. This Umi-side guard protects explicit/upstream Umi config; removing
antdfrom the internal Utoo default list is tracked separately in utooland/utoo#3117.Test
pnpm jest packages/bundler-utoopack/src/config.test.ts --runInBand