chore: remove unused hash util #375
Conversation
|
WalkthroughThis change updates dependency versions in Changes
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
💤 Files with no reviewable changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (21)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 9574478 in 41 seconds. Click for details.
- Reviewed
109lines of code in4files - Skipped
1files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. CHANGELOG.md:9
- Draft comment:
Updated contributor attribution for PR #371—make sure the correct contributors are recognized for each fix. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. package.json:80
- Draft comment:
Dependency version bumps (eslint-import-context and tsdown) are updated appropriately. Confirm these versions match downstream requirements. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. src/utils/hash.ts:1
- Draft comment:
Removal of the unused hash utility is clean. Verify no external modules depend on it. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. src/utils/index.ts:18
- Draft comment:
Removed export of './hash.js' in line with the deletion of the hash utility file. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_U7M4smYzAxdinxeq
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unused hashing utility, bumps two development dependencies, and refines contributor acknowledgements in the changelog.
- Removed export of the unused
hash.jsutil and deleted its source file. - Upgraded
eslint-import-contextfrom v0.1.7 to v0.1.8 andtsdownfrom v0.12.6 to v0.12.7. - Updated CHANGELOG.md entries for PR #371 to include additional contributor mentions.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/utils/index.ts | Removed export of unused hash.js. |
| src/utils/hash.ts | Deleted unused hash utility implementation. |
| package.json | Bumped eslint-import-context to v0.1.8 and tsdown to v0.12.7. |
| CHANGELOG.md | Expanded contributor acknowledgements for PR #371 fixes. |
Comments suppressed due to low confidence (2)
CHANGELOG.md:11
- [nitpick] The second bullet for PR #371 only thanks @JounQin; consider also acknowledging @dword-design for consistency with the first entry.
+ [#371](https://github.com/un-ts/eslint-plugin-import-x/pull/371) [`4f97a1a`](https://github.com/un-ts/eslint-plugin-import-x/commit/4f97a1a1419c15821ba1ab07e4038b715208ac7a) Thanks [@JounQin](https://github.com/JounQin)! - fix: enable `nocomment: true` for glob options of rules `no-import-module-exports` and `no-namespace`
package.json:83
- Dependency versions were updated; please remember to update and commit the lockfile (e.g., package-lock.json or yarn.lock) to ensure reproducible installs.
"eslint-import-context": "^0.1.8",
commit: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
package.json (2)
83-83: Confirm bump of eslint-import-context and document it.
Ensure upgrading to^0.1.8is compatible with existing rules and peer dependencies. Consider adding a note under “4.15.1” inCHANGELOG.mdto document this dependency bump.
164-164: Validate tsdown update and update documentation.
Verify thattsdown@^0.12.7produces correct build artifacts without regressions. If this change affects the build output or workflow, please add a corresponding entry inCHANGELOG.md.CHANGELOG.md (2)
9-9: Consolidate duplicate PR entry.
PR #371 appears twice with the same commit (4f97a1a…). Merge these two bullets into one under “4.15.1” and list both fixes together to avoid repetition.
11-11: Unify author attribution for PR #371.
The second bullet credits only [@JounQin] while the first credits both [@dword-design] and [@JounQin]. Please make the author listing consistent across both entries.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)package.json(2 hunks)src/utils/hash.ts(0 hunks)src/utils/index.ts(0 hunks)
💤 Files with no reviewable changes (2)
- src/utils/index.ts
- src/utils/hash.ts
⏰ Context from checks skipped due to timeout of 90000ms (21)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: autofix
- GitHub Check: Lint and Test with Node.js 24 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on macos-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 9 on macos-latest
- GitHub Check: publish
- GitHub Check: Analyze (actions)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 9 on windows-latest
- GitHub Check: Lint and Test with Node.js 20 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8 on windows-latest
- GitHub Check: Lint and Test with Node.js 24 and ESLint 8.56 on macos-latest
- GitHub Check: Lint and Test with Node.js 18 and ESLint 8.56 on ubuntu-latest
- GitHub Check: Lint and Test with Node.js 22 and ESLint 9 on macos-latest
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 7c85b19 in 1 minute and 23 seconds. Click for details.
- Reviewed
220lines of code in5files - Skipped
1files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. CHANGELOG.md:9
- Draft comment:
Changelog update looks good – the contributor attribution formatting has been adjusted consistently. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only states that the changelog update looks good and mentions formatting consistency. It doesn't provide any actionable feedback or suggestions for improvement.
2. package.json:80
- Draft comment:
Updated 'eslint-import-context' from ^0.1.7 to ^0.1.8. This dependency bump is clear; ensure it aligns with its usage in the code. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to ensure that the dependency bump aligns with its usage in the code. This falls under the rule of not asking the author to ensure compatibility or test changes, which is not allowed.
3. package.json:161
- Draft comment:
Bumped 'tsdown' from ^0.12.6 to ^0.12.7. Confirm that this new version is compatible with the build scripts. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm compatibility of a dependency version change, which violates the rule against asking for confirmation or verification of intentions. It also relates to dependency changes, which should not be commented on unless there's a specific suggestion or issue identified.
4. src/utils/index.ts:17
- Draft comment:
Removed the export of the unused hash utility (hash.js). This removal is consistent with deleting the file and its tests. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_oXEpOSgqxwPLRU0j
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
==========================================
- Coverage 96.04% 96.02% -0.03%
==========================================
Files 95 94 -1
Lines 4934 4907 -27
Branches 1851 1846 -5
==========================================
- Hits 4739 4712 -27
Misses 194 194
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Important
Remove unused hashing utilities and update changelog and dependencies for stability.
src/utils/hash.tsand their exports fromsrc/utils/index.ts.test/utils/hash.spec.tsas it tested the removed hashing utilities.CHANGELOG.mdto reflect contributor credits.eslint-import-contextto^0.1.8andtsdownto^0.12.7inpackage.json.This description was created by
for 7c85b19. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit