fix: prevent from adding duplicate github thumbprints #32
Conversation
There was a problem hiding this comment.
Thanks @witalisoft – I'll get this merged and released today, once the thumbprints are updated by GitHub, applying again should mean you can remove them from the additional_thumbprints variable, but there's no harm in ensuring that they're distinct anyway.
|
Just noticed this today too, really appreciate the quick action from y'all!! Great module, appreciate the support! |
|
One of the problems with this approach is that the thumbprints detected by auto-discovery on Github is not reliable and changing. This causes terraform to detect a change |
|
I went ahead and added both thumbprints to the By default the module only wanted to populate one value, and my understanding from that Github statement above was that we should include both thumbprints to prevent the chance of failures. So basically: module "aws_oidc_github_prod_orion_role" {
source = "unfunco/oidc-github/aws"
version = "1.5.1"
...
additional_thumbprints = [
"6938fd4d98bab03faadb97b34396831e3780aea1",
"1c58a3a8518e8759bf075b76b750d4f2df264fcd"
]Relevant line:
|
I've noticed that when I pass two GitHub thumbprints that are mentioned here . The "autodiscovery" also adds one of them, so I finish with some duplicate thumbprints.