Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Serial flag python #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Serial flag python #430

wants to merge 5 commits into from

Conversation

sven-oly
Copy link
Collaborator

@sven-oly sven-oly requested review from echeran and sffc March 31, 2025 23:45
@sffc
Copy link
Member

sffc commented Apr 1, 2025 •
edited
Loading

There is an error in CI:

~/work/conformance/conformance
~/work/conformance/conformance/schema ~/work/conformance/conformance
Traceback (most recent call last):
  File "/home/runner/work/conformance/conformance/schema/check_schemas.py", line 153, in <module>
    main(sys.argv)
  File "/home/runner/work/conformance/conformance/schema/check_schemas.py", line 99, in main
    validator.options = SchemaArgs(args).getOptions()
                        ^^^^^^^^^^
NameError: name 'SchemaArgs' is not defined. Did you mean: 'schemaArgs'?

sffc
sffc reviewed Apr 1, 2025
View reviewed changes
schema/check_generated_data.py Outdated
Comment on lines 15 to 17
# To get commanlin arguments
sys.path.append('../testdriver')
from ddtargs import schemaArgs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suspicious

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the comment. Note that this the same code used to import command arguments in other parts, e.g., verifier/verifier.py.

@sven-oly
Copy link
Collaborator Author

sven-oly commented Apr 1, 2025

I'll work on this now. I pushed too soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc left review comments

@echeran echeran Awaiting requested review from echeran

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven-oly @sffc