Drop the notation, compactDisplay, & numberingSystem options #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
approved these changes
Feb 17, 2025
| @@ -116,10 +116,10 @@ which makes it available for use in later _expressions_ and _markup_ _options_. | |||
| > For example, in | |||
| > ``` | |||
| > .input {$a :number minimumFractionDigits=3} | |||
| > .local $b = {$a :integer notation=compact} | |||
| > .local $b = {$a :integer useGrouping=never} | |||
There was a problem hiding this comment.
We should make this change regardless
Comment on lines
-76
to
-78
| > - ICU4J's implementation might _accept_ a `com.ibm.icu.text.NumberingSystem` object | ||
| > instead of using a [Unicode Numbering System Identifier](https://unicode.org/reports/tr35/tr35.html#UnicodeNumberSystemIdentifier) | ||
| > for the option `numberingSystem` in _functions_ such as `:number` or `:integer`. |
There was a problem hiding this comment.
In an ideal world we would find a replacement here, but not this morning.
|
Sure, if you want to do this and punt on the problem, fine with me. I'm not convinced compact notation should be moved to a separate function, but that's a discussion we can have at another time. |
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some of the issues identified in the ICU4X TC in the doc linked from #1006 (comment) by removing the notation, compactDisplay, and numberingSystem options from all functions that currently have them.
This is not a complete solution, nor is it the one preferred by the ICU4X TC, but for at least these options it's the simplest thing we can do, and as @aphillips notes in a comment on the doc:
The removal of
notationandcompactDisplaywas previously considered in #664, but dismissed on 2024-02-26.Regarding
numberingSystem, we should take it out for now and re-evaluate what shape its option ought to take after the '47 release. Again, quoting @aphillips: