Add tests for extended name character range #1020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Feb 18, 2025
aphillips
reviewed
Feb 18, 2025
| }, | ||
| { | ||
| "description": "various characters as unquoted-literal", | ||
| "src": "{\u00a1\u061d\u1681\u200b\u2010\u2030\u2060\u206a\u3001\ue000\ufdf0}", |
There was a problem hiding this comment.
Interesting to include some plane 1 and 2 characters?
There was a problem hiding this comment.
I just picked the first characters of each of the separate ranges beyond Latin-1 that are representable with JSON \u escapes.
There was a problem hiding this comment.
You can use JSON \u escapes--by employing a surrogate pair. But it's not important.
There was a problem hiding this comment.
You could have left your mark with the Finnish flag ;-)
There was a problem hiding this comment.
Sure, but 🥔 tastes better.
aphillips
approved these changes
Feb 18, 2025
macchiati
reviewed
Feb 18, 2025
macchiati
approved these changes
Feb 18, 2025
Co-authored-by: Mark Davis <[email protected]>
|
Meets fast-track. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for the changes made in #1008.