-
-
Notifications
You must be signed in to change notification settings - Fork 36
Define _option value_ and _digit size option_ #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start.
|
||
> [!NOTE] | ||
> Such information is irrelevant for _resolved values_ not used as the value of an _option_. | ||
> `select` be set with a _literal_ _option value_ (`plural`, `ordinal`, or `exact`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change here.
@@ -246,8 +241,7 @@ Its _resolved value_ is defined by _literal resolution_. | |||
the character sequence of the _text_ or _literal_ | |||
after any character escape has been converted to the escaped character. | |||
|
|||
When a _literal_ is used as an _operand_ | |||
or on the right-hand side of an _option_, | |||
When a _literal_ is used as an _operand_ or as an _option value_, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good improvement too!
Co-authored-by: Addison Phillips <[email protected]>
|
||
> [!NOTE] | ||
> Such information is irrelevant for _resolved values_ not used as the value of an _option_. | ||
> `select` be set with a _literal_ _option value_ (`plural`, `ordinal`, or `exact`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with removing the reason why we do this. We should someplace develop a companion piece that talks about some of these reasons, but they don't need to be in the spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not removed: it's moved to number selection.
Meets fast-track. Merging. |
Fixes #1034
Mostly the changes are straightforward and completely editorial, though I did opt to make a few further changes as I went:
:number select
added in Clarify option literalness details #1027 is moved from Resolved Values to Number SelectionI left out a definition of resolved options that I think we probably ought to add as well, but thought that the above could be done as a first step.