Define _option value_ and _digit size option_ #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
requested changes
Feb 21, 2025
|
|
||
| > [!NOTE] | ||
| > Such information is irrelevant for _resolved values_ not used as the value of an _option_. | ||
| > `select` be set with a _literal_ _option value_ (`plural`, `ordinal`, or `exact`). |
| @@ -246,8 +241,7 @@ Its _resolved value_ is defined by _literal resolution_. | |||
| the character sequence of the _text_ or _literal_ | |||
| after any character escape has been converted to the escaped character. | |||
|
|
|||
| When a _literal_ is used as an _operand_ | |||
| or on the right-hand side of an _option_, | |||
| When a _literal_ is used as an _operand_ or as an _option value_, | |||
There was a problem hiding this comment.
This is a good improvement too!
Co-authored-by: Addison Phillips <[email protected]>
eemeli
commented
Feb 21, 2025
eemeli
commented
Feb 21, 2025
aphillips
approved these changes
Feb 21, 2025
macchiati
approved these changes
Feb 21, 2025
|
|
||
| > [!NOTE] | ||
| > Such information is irrelevant for _resolved values_ not used as the value of an _option_. | ||
| > `select` be set with a _literal_ _option value_ (`plural`, `ordinal`, or `exact`). |
There was a problem hiding this comment.
I'm okay with removing the reason why we do this. We should someplace develop a companion piece that talks about some of these reasons, but they don't need to be in the spec
There was a problem hiding this comment.
It's not removed: it's moved to number selection.
|
Meets fast-track. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1034
Mostly the changes are straightforward and completely editorial, though I did opt to make a few further changes as I went:
:number selectadded in Clarify option literalness details #1027 is moved from Resolved Values to Number SelectionI left out a definition of resolved options that I think we probably ought to add as well, but thought that the above could be done as a first step.