Make expErrors use an array (and only an array) #1076
+14
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Jun 2, 2025
| @@ -5,7 +5,7 @@ | |||
| "defaultTestProperties": { | |||
| "bidiIsolation": "none", | |||
| "locale": "en-US", | |||
| "expErrors": false | |||
| "expErrors": [] | |||
There was a problem hiding this comment.
In fallback.md you left out expErrors. Here you supply an empty array. I think we should probably omit this one?
There was a problem hiding this comment.
@aphillips It's required in this file otherwise some tests would be left without an expectation (e.g. lines 44-55). This would also be the case in time.json.
As Eemeli mentioned in his review comment, I think we need to keep the expErrors in fallback.md.
| @@ -5,7 +5,7 @@ | |||
| "defaultTestProperties": { | |||
| "bidiIsolation": "none", | |||
| "locale": "en-US", | |||
| "expErrors": false | |||
| "expErrors": [] | |||
eemeli
reviewed
Jun 2, 2025
| @@ -4,8 +4,7 @@ | |||
| "description": "Test cases for fallback behaviour.", | |||
| "defaultTestProperties": { | |||
| "bidiIsolation": "none", | |||
| "locale": "en-US", | |||
| "expErrors": true | |||
There was a problem hiding this comment.
Was dropping this intentional? All of the messages in this file are expected to experience fallback and emit at least one error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #993