Fix registry.dtd to not use alternatives in function, formatSignature, matchSignature #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, matchSignature A spin-off from unicode-org#420, in which @mihnita noticed that `registry.dtd` uses alternatives in a wrong way. For example, `<!ELEMENT formatSignature (input?|option*)>` means that `formatSignature` is allowed to have as children either: at most one `input` OR any number of `options`, but not both. Instead, @mihnita suggested using sequences: `<!ELEMENT formatSignature (input?,option*)>`, which this PR does. Note that sequences require the children to appear in a specific order, which isn't something that's useful to us. However, I'm not aware of any way of lifting this requirement that also allows to enforce at most on `input` or exactly one `description`.
stasm
commented
Jul 23, 2023
spec/registry.dtd
Outdated
| @@ -1,6 +1,6 @@ | |||
| <!ELEMENT registry (function*|pattern*)> | |||
| <!ELEMENT registry (function|pattern)*> | |||
There was a problem hiding this comment.
In #420 @mihnita suggested changing this to:
<!ELEMENT registry (function,pattern)*>
...but IIUC, this requires function and pattern to appear one after the other, in this specific order, i.e. interleaved. Instead, in this PR I'm changing the original (function*|pattern*) — which wrongly meant any number of function OR any number of pattern, but never both — to (function|pattern)*.
eemeli
approved these changes
Jul 24, 2023
|
#420 was merged today, but before I rebase this PR on top of it, I'd like to make sure that we're OK with using DTD sequences: Using sequences here means that, for instance, the following <formatSignature>
<option name="dateStyle" values="full long medium short"/>
<input pattern="iso8601"/>
</formatSignature> |
I'm fine with that. |
aphillips
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A spin-off from #420, in which @mihnita noticed that
registry.dtduses alternatives in a wrong way. For example,<!ELEMENT formatSignature (input?|option*)>means thatformatSignatureis allowed to have as children either: at most oneinputOR any number ofoptions, but not both.Instead, @mihnita suggested using sequences:
<!ELEMENT formatSignature (input?,option*)>, which this PR does. Note that sequences require the children to appear in a specific order, which isn't something that's useful to us. However, I'm not aware of any way of lifting this requirement that also allows to enforce at most oninputor exactly onedescription.