Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(Design) Default registry and MF1 compatibility matrix #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

aphillips
Copy link
Member

@aphillips aphillips commented Dec 15, 2023

Create a list of selectors and formatters required by the default registry as well as a matrix showing how MF1 and MF2 map functionality.

This is an attempt to capture the current (and proposed) registry entries for the spring release. If we're missing something, it needs to get added.

🎵 ...he's making a list and checking it twice... 🎵

Create a list of selectors and formatters required by the default registry as well as a matrix showing how MF1 and MF2 map functionality. 

(NOT YET READY FOR REVIEW)
@aphillips aphillips added functions Issue pertains to the default function set LDML45 LDML45 Release (Tech Preview) labels Dec 15, 2023

_What is this proposal trying to achieve?_

This section contains the list of functions (both _selectors_ and _formatters_)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is quite a bit of duplication between this and what we already have in the registry.xml

What I thing is hight priority to address:

  • selectors, including decision on names: plural (cardinal & ordinal, with offset), select (or string?), maybe gender (maybe not now)
  • do we really want all the aliases?

I am afraid that we are reopening things that are already decided (formatters), and nobody complained about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, in fact, copied from registry.xml on purpose (thank you for making the original registry file). The only differences here should be the things proposed by @eemeli in the number selector PR. I wanted to have a way to discuss what goes into 2.0 without the clutter and to illustrate where we are vs. MF1.

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be mixing up two closely related but ultimately different things:

  1. Defining the initial full set of functions and their aliases.
  2. Documenting an MF1 → MF2 mapping.

I would find it easier to consider these separately, but I'm fine to also consider them together. If going the latter route, could we start with the functions and aliases on which we've previously reached (or are reaching) consensus, and leave out at least :currency, :percent, and :ordinal as a formatter? Any such additions ought to be argued for separately, as we've done for everything so far.

@aphillips
Copy link
Member Author

If going the latter route, could we start with the functions and aliases on which we've previously reached (or are reaching) consensus, and leave out at least :currency, :percent, and :ordinal as a formatter?

:currency and :percent are already in the registry, no?

:ordinal as a formatter is called out as missing from current consensus. It's weird to have the selector but not the formatter for that. I did, in fact, file an issue #565 for missing functionality (I also call for us not to include some functionality by consensus in the spring release)

This seems to be mixing up two closely related but ultimately different things:

Yes, that's true. However, I think there is a relationship between our minimum for launch and MF1 compatibility. Having a table that shows how we stack up turned out to be informative (to me). The real question is how we want to modify the aliases and options or if we want to include functions not listed here in the list that implementations are required to provide.

This item is, in fact, in the agenda for Monday.

@aphillips aphillips added the Agenda+ Requested for upcoming teleconference label Dec 16, 2023
@eemeli
Copy link
Collaborator

eemeli commented Dec 16, 2023

:currency and :percent are already in the registry, no?

No, they're not.

@aphillips
Copy link
Member Author

:currency and :percent are already in the registry, no?

No, they're not.

So what is this then?

      <option name="style" values="decimal currency percent unit" default="decimal">

I mean, yes, that's not a function named :currency and a function names :percent. But that is currency and percent formatting.

@eemeli
Copy link
Collaborator

eemeli commented Dec 17, 2023

I mean, yes, that's not a function named :currency and a function names :percent. But that is currency and percent formatting.

Correct. We support currency, percent, and unit formatting via the :number formatter's style option. We do not have a consensus decision on including aliases such as :currency and :percent, and I don't think we necessarily need them.

Compared to MF1, this is rather similar to having {x, number, percent} instead of {x, percent}.

@aphillips aphillips merged commit 4619bd8 into main Jan 8, 2024
@aphillips aphillips deleted the aphillips-default-registry-design branch January 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ Requested for upcoming teleconference functions Issue pertains to the default function set LDML45 LDML45 Release (Tech Preview)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants