-
-
Notifications
You must be signed in to change notification settings - Fork 36
(Design) Default registry and MF1 compatibility matrix #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Create a list of selectors and formatters required by the default registry as well as a matrix showing how MF1 and MF2 map functionality. (NOT YET READY FOR REVIEW)
|
||
_What is this proposal trying to achieve?_ | ||
|
||
This section contains the list of functions (both _selectors_ and _formatters_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is quite a bit of duplication between this and what we already have in the registry.xml
What I thing is hight priority to address:
- selectors, including decision on names: plural (cardinal & ordinal, with offset), select (or
string
?), maybe gender (maybe not now) - do we really want all the aliases?
I am afraid that we are reopening things that are already decided (formatters), and nobody complained about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is, in fact, copied from registry.xml
on purpose (thank you for making the original registry file). The only differences here should be the things proposed by @eemeli in the number selector PR. I wanted to have a way to discuss what goes into 2.0 without the clutter and to illustrate where we are vs. MF1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be mixing up two closely related but ultimately different things:
- Defining the initial full set of functions and their aliases.
- Documenting an MF1 → MF2 mapping.
I would find it easier to consider these separately, but I'm fine to also consider them together. If going the latter route, could we start with the functions and aliases on which we've previously reached (or are reaching) consensus, and leave out at least :currency
, :percent
, and :ordinal
as a formatter? Any such additions ought to be argued for separately, as we've done for everything so far.
Yes, that's true. However, I think there is a relationship between our minimum for launch and MF1 compatibility. Having a table that shows how we stack up turned out to be informative (to me). The real question is how we want to modify the aliases and options or if we want to include functions not listed here in the list that implementations are required to provide. This item is, in fact, in the agenda for Monday. |
No, they're not. |
So what is this then?
I mean, yes, that's not a function named |
Correct. We support currency, percent, and unit formatting via the Compared to MF1, this is rather similar to having |
Create a list of selectors and formatters required by the default registry as well as a matrix showing how MF1 and MF2 map functionality.
This is an attempt to capture the current (and proposed) registry entries for the spring release. If we're missing something, it needs to get added.
🎵 ...he's making a list and checking it twice... 🎵