Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add @attributes as reserved #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Add @attributes as reserved #592

merged 4 commits into from
Jan 13, 2024

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Jan 12, 2024

As discussed during this week's call, this adds @attributes to expression and markup with runtime impact.

For the syntax & data model, this is mostly a rebase of #450 that leaves out any discussion of what attributes might be good for, while noting that "Attributes are reserved for use by future specification versions."

For formatting, the language is rather more forbidding:

Attributes MUST NOT have any impact on message formatting, and MUST NOT be available in the formatted output. Variables in attribute values are not resolved, and no errors are emitted for them.

Closes #453, as using identifier brings in the same namespacing we're using for _options.

This also closes #587, as removing @ leaves the remaining symbols sorted in code point order.

@eemeli eemeli added syntax Issues related with syntax or ABNF data model Issues related to the Interchange Data Model formatting Issue pertains to the formatting section of the spec LDML45 LDML45 Release (Tech Preview) labels Jan 12, 2024
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Some suggestions.

Co-authored-by: Addison Phillips <[email protected]>
Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notwithstanding my comment, I'm going to add a 'ship it' here. I'd like to merge this with one more positive review.

@aphillips aphillips merged commit c9c68a1 into main Jan 13, 2024
@eemeli eemeli deleted the reserve-expression-attributes branch January 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model Issues related to the Interchange Data Model formatting Issue pertains to the formatting section of the spec LDML45 LDML45 Release (Tech Preview) syntax Issues related with syntax or ABNF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort the reserved sigils, check for completeness What is the namespace for expression attributes ?
2 participants