Split errors into their own section #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
reviewed
Jan 12, 2024
| @@ -43,7 +43,7 @@ Formatting of a _message_ is defined by the following operations: | |||
|
|
|||
| At the start of _pattern selection_, | |||
| if the _message_ contains any _reserved statements_, | |||
| emit an Unsupported Statement Error. | |||
| emit an _Unsupported Statement_ error. | |||
There was a problem hiding this comment.
Should "error" be part of the error name as it is with other types of errors? We should be consistent. (I see this below with Unsupported Expression and some others as well, but won't flag them pending discussion)
There was a problem hiding this comment.
See my first comment; the practice introduced here is to consistently include "Errors" in the category names, but not in the specific ones.
Co-authored-by: Addison Phillips <[email protected]>
aphillips
approved these changes
Jan 15, 2024
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #583
Conflicts a bit with #577 and #580, which will need to be updated.
The following naming styles are adopted and applied:
Effectively, categories include "Error", capitalized, but specific named data model & resolution errors do not. This is intended to help match error identifiers across implementations, and to make it convenient to present them together with their category, such as:
The sole named "Selector error" under Selection Errors is dropped, as it wasn't even referred to by that name in the formatting text.
The error handling section that was previously at the very end is moved up and slightly edited.