-
-
Notifications
You must be signed in to change notification settings - Fork 36
Add options to close (spec) #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to close (spec) #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There might be a quibble about whether we want separate open/standalone/close productions or separate /
from }
on standalone, but I think this is pretty darned clean.
Thanks!!
ACK. I thought about this, and decided to use this style to bring it closer to the json data model, where we have 3 completely separated structures for markup-open/standalone/close. They are also not unified in the data-model/README:
On the other side, in the data-model dtd they are all unified. I would prefer the unified style. So the readme would be more like
But I didn't want to include anything controversial. |
I would also like to fix this issue: "Extra spaces in markup #650" (that I've just created) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall ok, but see inline simplifications.
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
Co-authored-by: Eemeli Aro <[email protected]>
All feedback implemented, thank you all! |
Co-authored-by: Eemeli Aro <[email protected]>
Closes #636