[DESIGN] Add user stories / build-out of the expression attributes #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute design Add user-stories and examples to the expression attributes design.
eemeli
reviewed
May 14, 2024
There was a problem hiding this comment.
Looks pretty good. The quoting of e.g. "locale" and "direction" in text looks a bit odd, and the code examples probably don't need > indentation.
A third user story could be added to account for the use case introduced in #772.
Remember to add this PR to the "Pull Requests" list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user-stories and examples to the expression attributes design.