Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add hour12 date/time override option #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add hour12 date/time override option #948

merged 1 commit into from
Nov 19, 2024

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Nov 18, 2024 •
edited
Loading

This is the part of the changes originally proposed in #911 that was deemed as immediately mergeable on today's call.

Perhaps a little pre-emptively, it adopts the nomenclature to be introduced in #946.

This PR is expected to be followed up with separate PRs for the RECOMMENDED override options.

@eemeli eemeli added functions Issue pertains to the default function set fast-track Editorial change permitted to use fast-track merge rules LDML46.1 MF2.0 Draft Candidate labels Nov 18, 2024
@mihnita
Copy link
Collaborator

mihnita commented Nov 18, 2024

Looking at the whole file, it looks like the way "Date/time override options" is added to :datetime and :time is inconsistent.

:datetime has it in text, but not in the list of options:

The :datetime function can use either the appropriate style options or can use a collection of field options (but not both) to control the formatted output. Date/time override options can be combined with either style options or field options.

Which is kind of hard to discover.

:time has it in the bulleted list of options

:date has it in the bulleted list of options

But it should not have it at all.
Because right now the only Date/time override option is "hour12"
Which does not apply to dates (they don't have an hour field).

@aphillips
Copy link
Member

This meets fast-track requirements and was approved in the 2024-11-18 call previously.

@aphillips aphillips merged commit 4da01dc into main Nov 19, 2024
1 check passed
@aphillips aphillips deleted the datetime-hour12 branch November 19, 2024 01:06
@mihnita
Copy link
Collaborator

mihnita commented Nov 19, 2024

was approved in the 2024-11-18 call previously

Allowing hour12 on :date is clearly wrong.
We do that just because was approved for fast-track?

The fix for that would be simple: remove it from :date

I can live with the option "hidden in text" for :datetime
It is a bit hard to discover, but not wrong.

mihnita
mihnita reviewed Nov 19, 2024
View reviewed changes
spec/registry.md
@@ -995,6 +992,7 @@ The function `:date` has these _options_:
- `long`
- `medium` (default)
- `short`
- _Date/time override options_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.
The overrides right now only support hour12, which is not valid on dates.

This was referenced Nov 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihnita mihnita mihnita left review comments

@aphillips aphillips aphillips approved these changes

@macchiati macchiati macchiati approved these changes

Assignees
No one assigned
Labels
fast-track Editorial change permitted to use fast-track merge rules functions Issue pertains to the default function set LDML46.1 MF2.0 Draft Candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eemeli @mihnita @aphillips @macchiati